Closed
Bug 1101342
Opened 10 years ago
Closed 10 years ago
[jsdbg2] Some comments are out of date or unclear
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file)
4.19 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
- Remove comment reference to removed JSCompartment::addDebuggee. - Clarify comments in js::DebugScript. - Add back form feeds separating sections of Debugger.cpp.
Attachment #8525074 -
Flags: review?(shu)
Comment 1•10 years ago
|
||
Comment on attachment 8525074 [details] [diff] [review] Debugger-related comment fixes. Review of attachment 8525074 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. ::: js/src/vm/Debugger.cpp @@ +2973,5 @@ > + * For global to become this js::Debugger's debuggee: > + * - global must be in this->debuggees, > + * - this js::Debugger must be in global->getDebuggers(), and > + * - JSCompartment::isDebuggee()'s bit must be set. > + * All three indications must be kept consistent. Ah, thanks for fixing the stale reference to debug mode.
Attachment #8525074 -
Flags: review?(shu) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Thanks for the review! https://hg.mozilla.org/integration/mozilla-inbound/rev/e46da4d0299d
Assignee: nobody → jimb
Severity: normal → trivial
Flags: in-testsuite-
Target Milestone: --- → mozilla36
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e46da4d0299d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•