Handle the "add favorite contact" activity from the Contacts app after the user selects a contact

RESOLVED WONTFIX

Status

Firefox OS
Gaia::Dialer
RESOLVED WONTFIX
4 years ago
4 months ago

People

(Reporter: drs, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [planned-sprint c=?])

(Reporter)

Description

4 years ago
When the user selects a contact to be added as a favorite contact (bug 1101347) through the favorite contacts banner (bug 1099398), we must handle the resulting activity and actually add the contact as a favorite.

This doesn't truly depend on bug 1101347, but QA will have a very hard time verifying this without that bug being done first.
(Reporter)

Updated

4 years ago
Blocks: 1101351
(Reporter)

Comment 1

4 years ago
I think that this would probably be better implemented within the Contacts app. Francisco had a great idea of implementing a web component for contacts selection, but I think that's outside the scope of this feature and release, and is something we can do at a later time.

Francisco, do you have any thoughts on this? I think that it would be best if the entire process was done within the Contacts app, and the Dialer just got a notification through the DataStore that the favorite contacts have been updated. (bug 1101353)

I'm not happy that we'd have to do validation within the Contacts app in this case, e.g. making sure the user isn't trying to add a contact as a favorite that is already a favorite. But the big advantage here is that we wouldn't need write access to the DB, for the Dialer.

If you agree, we can begin filing bugs within the Contacts app. Otherwise, we can discuss further. My knowledge here is fairly shallow, so any insight you have would be valuable.
Flags: needinfo?(francisco)
See Also: → bug 1101353
Assignee: nobody → jlorenzo
Assignee: jlorenzo → nobody
QA Contact: jlorenzo
(In reply to Doug Sherk (:drs) (use needinfo?) from comment #1)

> Francisco, do you have any thoughts on this? I think that it would be best
> if the entire process was done within the Contacts app, and the Dialer just
> got a notification through the DataStore that the favorite contacts have
> been updated. (bug 1101353)
> 

Right, contacts can take care of offering a web activity for doing all the process.

Favorites now are store in the mozcontacts db (category=favorite you can use it as filter in mozContacts.find), we can provide a web activity and take care of the corner cases in contacts.

Dialer will need to listen to contactChange event to be sure that updates favorite list if a contact just changed.

> 
> If you agree, we can begin filing bugs within the Contacts app. Otherwise,
> we can discuss further. My knowledge here is fairly shallow, so any insight
> you have would be valuable.

Please do :), we will be happy to create the web activity for you, should not be much work.
Flags: needinfo?(francisco)

Comment 3

4 months ago
Firefox OS is not being worked on
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.