[Stingray][home] apply visual to information block

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: johnhu, Assigned: johnhu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 attachment)

Please apply the visual to information block(p4), button set of edit mode(p5), and related building block.
No longer depends on: 1101367
Edit mode is excluded because we don't implement that feature. This issue only needs to apply the information block (p4).
Summary: [Stingray][home] apply visual to information block and button set of edit mode → [Stingray][home] apply visual to information block
Assignee: nobody → im
Created attachment 8528129 [details] [review]
visual applied

Please review this patch. Thanks.

The changes are:
1. remove original fake clock
2. add Clock.js and use it to show the clock lively
3. apply clock visual
4. add fake weather info block and apply visual.
Attachment #8528129 - Flags: review?(tzhuang)
Comment on attachment 8528129 [details] [review]
visual applied

Looks good to me. Thanks

But it seems that you need to rebase to latest master before landing. There might be conflict.
Attachment #8528129 - Flags: review?(tzhuang) → review+
Blocks: 1105576
merged to master:
https://github.com/mozilla-b2g/gaia/commit/acfe13956247d9c09901d1ef7065b9cbd34c77ad

gaia-try with one failed which is a known intermittent issue
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=cc1bee8bf184
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Correction: This doesn't break initialization (since it's executed asynchronously) so it's not a critical problem. You can fix it later.
Thanks,

I already had the patch in bug 1101373.
Flags: needinfo?(im)
You need to log in before you can comment on or make changes to this bug.