1101369 - [Stingray][home] apply visual to information block

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

Please apply the visual to information block(p4), button set of edit mode(p5), and related building block.

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Edit mode is excluded because we don't implement that feature. This issue only needs to apply the information block (p4).

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: visual applied

Please review this patch. Thanks.

The changes are:
1. remove original fake clock
2. add Clock.js and use it to show the clock lively
3. apply clock visual
4. add fake weather info block and apply visual.

Comment 3

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8528129 [details] [review]
visual applied

Looks good to me. Thanks

But it seems that you need to rebase to latest master before landing. There might be conflict.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/acfe13956247d9c09901d1ef7065b9cbd34c77ad

gaia-try with one failed which is a known intermittent issue
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=cc1bee8bf184

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

This patch contains javascript error and breaks initialization of home.js.

Please open another bug to fix it.

https://github.com/mozilla-b2g/gaia/commit/acfe13956247d9c09901d1ef7065b9cbd34c77ad#diff-5a33a94cd737c2a136a3c3139f952015R75
https://github.com/mozilla-b2g/gaia/commit/acfe13956247d9c09901d1ef7065b9cbd34c77ad#diff-5a33a94cd737c2a136a3c3139f952015R78

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Correction: This doesn't break initialization (since it's executed asynchronously) so it's not a critical problem. You can fix it later.

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Thanks,

I already had the patch in bug 1101373.