1101461 - Investigate the possibility to utilize new chai version for unit tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

+++ This bug was initially created as a clone of Bug #1070487 +++

As I said in bug 1070487 comment 4:

> In the past, we had deliberately ignored prototype-checking because doing
> that was particularly a hassle (since |assert.deepEqual| was not checking
> prototypes). Yet, for the sake of proper testing, we should've actually been
> checking prototypes for most of the cases.
> 
> I'd really like to see if the tests can be modified to formally account for
> checking prototypes, instead of hacking current logics to circumvent
> side-effects that've been brought by newer, prototype-checking
> |assert.deepEqual| (essentially, we would be double-hacking to realize
> something that should've been there in the first place, had we had
> prototype-checking |assert.deepEqual| back then).
> 
> With that said, to bring these formal test changes, we probably need
> somebody who's familiar with the keyboard testing logics and the inner
> rationals of those modules being tested; I do understand it can be
> unreasonable to require this patch (which, for the purpose of this bug, is
> just to bridge compatibility with newer chai.assert) to account for those
> formal changes.

Let's see how much work it's gonna be.

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

I'm looking into this right now.

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch (PR @ GitHub)

Let's see if Gu is happy on this.

Comment 3

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8539950 [details] [review]
Patch (PR @ GitHub)

Gu is good. Rudy, could you check this quick patch? Thanks!

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8539950 [details] [review]
Patch (PR @ GitHub)

Looks good to me. Thanks!

Comment 5

[John Lu [:mnjul][Please NI or I'll miss]]

Master: https://github.com/mozilla-b2g/gaia/commit/d5826b4a0015bdd047ac5d58830ab37822406701