1101537 - [RTL] list item and headers are not aligned properly in RTL

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Hubert Figuiere [:hub]]

In Arabic (RTL), the letter of the header should be aligned to the left. And the line is too short.

Comment 1

[Hubert Figuiere [:hub]]

I mean the letter should be aligned to the right. Like the text. Which is ignoring the margin.

It seems to be all related.

Comment 2

[Hubert Figuiere [:hub]]

Bug 1074546 is part of why.

Comment 3

[Hubert Figuiere [:hub]]

Attachment: Link to pull request

David, if you think somebody else should review, let me know.

Comment 4

[Hubert Figuiere [:hub]]

Comment on attachment 8525349 [details] [review]
Link to pull request

Jim, can you?

Comment 5

[Jim Porter (:squib)]

Comment on attachment 8525349 [details] [review]
Link to pull request

See my comments on GitHub. It's a lot easier to use -moz-margin-start and -moz-margin-end, (likewise for padding) and those are explicitly recommended for RTL support in FxOS.

Comment 6

[Hubert Figuiere [:hub]]

Actually I disagree. Will comment locally and explain why.

Comment 7

[Hubert Figuiere [:hub]]

Comment on attachment 8525349 [details] [review]
Link to pull request

Updated the Pull Request with the feedback.

Thanks.

Comment 8

[Jim Porter (:squib)]

Comment on attachment 8525349 [details] [review]
Link to pull request

Looks good, aside from one small nit on GitHub. And good catch with the -moz-margin-start stuff!

(Note that I didn't actually flash this patch, but it's simple enough that I don't think anything will *break*.)

Comment 9

[Hubert Figuiere [:hub]]

Merged
https://github.com/mozilla-b2g/gaia/commit/4431afd37155995eace2ca377d82ccbd3378633c

Comment 10

[Elie]

Hey Hubert
Please provice reproduce step to tester for verification.Thanks!

Comment 11

[Elie]

I examine the list item and headers of Playlist Artists Ablums and Songs view in Music,it seems that  the letter of the header is aligned to the left.
I thinks this issue is verified successfully on Flame 2.2:
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/bccee1a13ba6
Build-ID        20150119002502
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2

Hi Hubert, I have recorded test steps,refer to video VIDEO0265.mp4.Please confirm that my test steps
are correct.

Comment 12

[Elie]

Attachment: VIDEO0265.mp4

Comment 13

[Elie]

Please refer to comment 11&12

Comment 14

[Hubert Figuiere [:hub]]

Yes it is correct.

Comment 15

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15196/