[RTL] list item and headers are not aligned properly in RTL

VERIFIED FIXED in Firefox OS v2.2

Status

VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: hub, Assigned: hub)

Tracking

unspecified
2.1 S9 (21Nov)
x86_64
Linux
Bug Flags:
in-moztrap +

Firefox Tracking Flags

(b2g-v2.2 verified)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
In Arabic (RTL), the letter of the header should be aligned to the left. And the line is too short.
(Assignee)

Updated

4 years ago
Assignee: nobody → hub
Blocks: 1071890
(Assignee)

Comment 1

4 years ago
I mean the letter should be aligned to the right. Like the text. Which is ignoring the margin.

It seems to be all related.
(Assignee)

Comment 2

4 years ago
Bug 1074546 is part of why.
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Summary: [RTL] list item headers are not aligned properly in RTL → [RTL] list item and headers are not aligned properly in RTL
(Assignee)

Comment 3

4 years ago
Created attachment 8525349 [details] [review]
Link to pull request

David, if you think somebody else should review, let me know.
Attachment #8525349 - Flags: review?(dflanagan)
(Assignee)

Comment 4

4 years ago
Comment on attachment 8525349 [details] [review]
Link to pull request

Jim, can you?
Attachment #8525349 - Flags: review?(dflanagan) → review?(squibblyflabbetydoo)

Comment 5

4 years ago
Comment on attachment 8525349 [details] [review]
Link to pull request

See my comments on GitHub. It's a lot easier to use -moz-margin-start and -moz-margin-end, (likewise for padding) and those are explicitly recommended for RTL support in FxOS.
Attachment #8525349 - Flags: review?(squibblyflabbetydoo) → review-
(Assignee)

Comment 6

4 years ago
Actually I disagree. Will comment locally and explain why.
(Assignee)

Comment 7

4 years ago
Comment on attachment 8525349 [details] [review]
Link to pull request

Updated the Pull Request with the feedback.

Thanks.
Attachment #8525349 - Flags: review- → review?(squibblyflabbetydoo)

Comment 8

4 years ago
Comment on attachment 8525349 [details] [review]
Link to pull request

Looks good, aside from one small nit on GitHub. And good catch with the -moz-margin-start stuff!

(Note that I didn't actually flash this patch, but it's simple enough that I don't think anything will *break*.)
Attachment #8525349 - Flags: review?(squibblyflabbetydoo) → review+
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.2: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S9 (21Nov)

Updated

4 years ago
Keywords: verifyme

Comment 10

4 years ago
Hey Hubert
Please provice reproduce step to tester for verification.Thanks!
Flags: needinfo?(hub)

Comment 11

4 years ago
I examine the list item and headers of Playlist Artists Ablums and Songs view in Music,it seems that  the letter of the header is aligned to the left.
I thinks this issue is verified successfully on Flame 2.2:
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/bccee1a13ba6
Build-ID        20150119002502
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2

Hi Hubert, I have recorded test steps,refer to video VIDEO0265.mp4.Please confirm that my test steps
are correct.
Status: RESOLVED → VERIFIED
status-b2g-v2.2: fixed → verified
Flags: needinfo?(hub)
Keywords: verifyme

Comment 12

4 years ago
Created attachment 8551669 [details]
VIDEO0265.mp4

Comment 13

4 years ago
Please refer to comment 11&12
Flags: needinfo?(hub)
(Assignee)

Comment 14

4 years ago
Yes it is correct.
Flags: needinfo?(hub)

Updated

4 years ago
Flags: in-moztrap+
Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15196/
You need to log in before you can comment on or make changes to this bug.