Closed
Bug 1101601
Opened 10 years ago
Closed 9 years ago
Double-clicking a line should work to add a review comment
Categories
(MozReview Graveyard :: General, enhancement, P1)
MozReview Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ted, Unassigned)
References
Details
Attachments
(1 file)
Right now you have to click on the line number to add a review comment. I'm used to being able to double-click on a line itself to add a comment (this works in Splinter and Rietveld). It would be nice if this worked in ReviewBoard as well.
Comment 1•10 years ago
|
||
This should be filed upstream. https://code.google.com/p/reviewboard/issues/list
Comment 2•10 years ago
|
||
Fixed in core 2.5, which is almost in beta. WONTFIXing it as part of MozReview specifically.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Comment 5•10 years ago
|
||
Actually, I'll leave this open until it's in our deployment.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Updated•10 years ago
|
Status: REOPENED → NEW
Updated•10 years ago
|
Whiteboard: [fixed in core]
Updated•10 years ago
|
Priority: -- → P1
Comment 9•9 years ago
|
||
It looks like mconley's fix in core is going to be backed out [1]. We'll need to work his patch [2] into the mozreview extension instead.
[1] https://hellosplat.com/s/beanbag/tickets/4018/
[2] https://reviews.reviewboard.org/r/6881/diff/3#index_header
Whiteboard: [fixed in core]
Comment 10•9 years ago
|
||
mozreview: make double-clicks open review comments on diffviewer (bug 1101601); r?mdoglio
Attachment #8690617 -
Flags: review?(mdoglio)
Updated•9 years ago
|
Attachment #8690617 -
Flags: review?(mdoglio) → review+
Comment 11•9 years ago
|
||
Comment on attachment 8690617 [details]
MozReview Request: mozreview: make double-clicks open review comments on diffviewer (bug 1101601); r?mdoglio
https://reviewboard.mozilla.org/r/25891/#review23317
This is simply awesome!
Comment 12•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago → 9 years ago
Resolution: --- → FIXED
Comment 13•9 years ago
|
||
This is live on production now.
![]() |
||
Comment 14•9 years ago
|
||
For what it's worth, the behavior this introduced is probably the #1 thing making mozreview painful to use for me today... :(
Depends on: 1246769
Assignee | ||
Updated•9 years ago
|
Product: Developer Services → MozReview
Comment 15•9 years ago
|
||
This feature has been backed out and turned into a browser extension instead:
https://addons.mozilla.org/en-US/firefox/addon/rb-doubleclick/
You need to log in
before you can comment on or make changes to this bug.
Description
•