Closed Bug 1101601 Opened 7 years ago Closed 6 years ago

Double-clicking a line should work to add a review comment

Categories

(MozReview Graveyard :: General, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ted, Unassigned)

References

Details

Attachments

(1 file)

Right now you have to click on the line number to add a review comment. I'm used to being able to double-click on a line itself to add a comment (this works in Splinter and Rietveld). It would be nice if this worked in ReviewBoard as well.
Fixed in core 2.5, which is almost in beta.  WONTFIXing it as part of MozReview specifically.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Duplicate of this bug: 1102863
Duplicate of this bug: 1109092
Actually, I'll leave this open until it's in our deployment.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Duplicate of this bug: 1123146
Status: REOPENED → NEW
Whiteboard: [fixed in core]
Priority: -- → P1
Duplicate of this bug: 1178029
Duplicate of this bug: 1203795
It looks like mconley's fix in core is going to be backed out [1]. We'll need to work his patch [2] into the mozreview extension instead.

[1] https://hellosplat.com/s/beanbag/tickets/4018/
[2] https://reviews.reviewboard.org/r/6881/diff/3#index_header
Whiteboard: [fixed in core]
Attachment #8690617 - Flags: review?(mdoglio) → review+
Comment on attachment 8690617 [details]
MozReview Request: mozreview: make double-clicks open review comments on diffviewer (bug 1101601); r?mdoglio

https://reviewboard.mozilla.org/r/25891/#review23317

This is simply awesome!
https://hg.mozilla.org/hgcustom/version-control-tools/rev/7014000ff305
Status: NEW → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
This is live on production now.
Depends on: 1239905
For what it's worth, the behavior this introduced is probably the #1 thing making mozreview painful to use for me today... :(
Depends on: 1246769
Product: Developer Services → MozReview
This feature has been backed out and turned into a browser extension instead:

https://addons.mozilla.org/en-US/firefox/addon/rb-doubleclick/
You need to log in before you can comment on or make changes to this bug.