Double-clicking a line should work to add a review comment

RESOLVED FIXED

Status

MozReview
General
P1
enhancement
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: ted, Unassigned)

Tracking

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Right now you have to click on the line number to add a review comment. I'm used to being able to double-click on a line itself to add a comment (this works in Splinter and Rietveld). It would be nice if this worked in ReviewBoard as well.
This should be filed upstream. https://code.google.com/p/reviewboard/issues/list

Comment 2

3 years ago
Fixed in core 2.5, which is almost in beta.  WONTFIXing it as part of MozReview specifically.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX

Updated

3 years ago
Duplicate of this bug: 1102863

Updated

3 years ago
Duplicate of this bug: 1109092

Comment 5

3 years ago
Actually, I'll leave this open until it's in our deployment.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---

Updated

3 years ago
Duplicate of this bug: 1123146

Updated

3 years ago
Status: REOPENED → NEW

Updated

3 years ago
Whiteboard: [fixed in core]

Updated

3 years ago
Priority: -- → P1

Updated

2 years ago
Duplicate of this bug: 1178029

Updated

2 years ago
Duplicate of this bug: 1203795

Comment 9

2 years ago
It looks like mconley's fix in core is going to be backed out [1]. We'll need to work his patch [2] into the mozreview extension instead.

[1] https://hellosplat.com/s/beanbag/tickets/4018/
[2] https://reviews.reviewboard.org/r/6881/diff/3#index_header
Whiteboard: [fixed in core]
Created attachment 8690617 [details]
MozReview Request: mozreview: make double-clicks open review comments on diffviewer (bug 1101601); r?mdoglio

mozreview: make double-clicks open review comments on diffviewer (bug 1101601); r?mdoglio
Attachment #8690617 - Flags: review?(mdoglio)
Attachment #8690617 - Flags: review?(mdoglio) → review+
Comment on attachment 8690617 [details]
MozReview Request: mozreview: make double-clicks open review comments on diffviewer (bug 1101601); r?mdoglio

https://reviewboard.mozilla.org/r/25891/#review23317

This is simply awesome!
https://hg.mozilla.org/hgcustom/version-control-tools/rev/7014000ff305
Status: NEW → RESOLVED
Last Resolved: 3 years ago2 years ago
Resolution: --- → FIXED
This is live on production now.
Depends on: 1239905
For what it's worth, the behavior this introduced is probably the #1 thing making mozreview painful to use for me today... :(
Depends on: 1246769
See Also: → bug 1249297
(Assignee)

Updated

2 years ago
Product: Developer Services → MozReview
This feature has been backed out and turned into a browser extension instead:

https://addons.mozilla.org/en-US/firefox/addon/rb-doubleclick/
You need to log in before you can comment on or make changes to this bug.