Closed Bug 1101603 Opened 10 years ago Closed 10 years ago

[RTL] Player not working properly in RTL

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)

Status:
VERIFIED FIXED
Milestone:
2.2 S1 (5dec)
Project Flags:
feature-b2g 2.2+
Tracking Flags:
Tracking Status
b2g-v2.2 --- verified
b2g-master --- verified

People

(Reporter: hub, Assigned: hub)

References

Details

(Whiteboard: [ft:media])

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26362
46 bytes, text/x-github-pull-request
squib
: review+
Details | Review 
Fix the player in RTL mode according to the UX.
Blocks: music-rtl
Assignee: nobody → hub
Status: NEW → ASSIGNED
Target Milestone: --- → 2.1 S9 (21Nov)
feature-b2g: --- → 2.2+
Whiteboard: [ft:media]
Target Milestone: 2.1 S9 (21Nov) → 2.2 S1 (5dec)
Just added another change to the PR (separate commit for now) to fix the rating widget. This wasn't in the spec.

Thank you kindly.
Comment on attachment 8526791 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26362

r+ with some comments on GitHub.
Attachment #8526791 - Flags: review?(squibblyflabbetydoo) → review+
Merged 
https://github.com/mozilla-b2g/gaia/commit/62ad3aec1cbb5a18fecb20f3dea2a70bcb9fefe4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Keywords: verifyme
Hi Hubert
Please provice the test steps and expect behvior to tester for verification this issue.Thanks~
Flags: needinfo?(hub)
Flags: in-moztrap+
This issue is verified fixed on Flame 3.0 and Flame 2.2

The user can skip forward/backward, scrub through, Pause/Play, and rate songs in RTL properly without issue. The music player is also properly displayed based on page 14 of this spec sheet: https://mozilla.app.box.com/s/0y1amh4rwpp6brcxd1hk

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150205010209
Gaia: 2b83a6d5d1185a438b5bbd287497ac2743b501db
Gecko: 34a66aaaca81
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0


Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150205002503
Gaia: c2047a46e29696238e9b4c9caaba47736421449a
Gecko: adfba0a07e9b
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?][rtl-impact]
status-b2g-v2.2: --- → verified
status-b2g-master: --- → verified
Flags: needinfo?(pbylenga)
Keywords: verifyme
QA Whiteboard: [QAnalyst-Triage?][rtl-impact] → [QAnalyst-Triage+][rtl-impact]
Flags: needinfo?(pbylenga)
Flags: needinfo?(hub)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: