Closed
Bug 1101648
Opened 10 years ago
Closed 10 years ago
UITour needs a way to detect which engine is currently selected
Categories
(Firefox :: Search, defect)
Firefox
Search
Tracking
()
People
(Reporter: Gavin, Assigned: Felipe)
References
Details
Attachments
(1 file, 2 obsolete files)
2.47 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
We may use this to inform the tour people get if we switch default search engines (e.g. if people are already using the existing default, don't show them anything about the change). We can probably use getConfiguration for this, and just add a "selectedSearch" type that returns the selected search engine's identifier (to be consistent with other UITour search-related APIs).
Reporter | ||
Updated•10 years ago
|
Group: mozilla-employee-confidential
Assignee | ||
Comment 1•10 years ago
|
||
Who should review this?
Attachment #8526123 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 2•10 years ago
|
||
Being cautious and wrapping the code around a Services.search.init
Attachment #8526143 -
Flags: review?(gavin.sharp)
Attachment #8526143 -
Flags: review?(dolske)
Assignee | ||
Updated•10 years ago
|
Attachment #8526123 -
Attachment is obsolete: true
Attachment #8526123 -
Flags: review?(gavin.sharp)
Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8526143 [details] [diff] [review] getSelectedEngine I think we should only send the identifier, I don't see any valid uses for the name and it could be potentially confusing. The test should also in theory use the async init API. r=me with those.
Attachment #8526143 -
Flags: review?(gavin.sharp)
Attachment #8526143 -
Flags: review?(dolske)
Attachment #8526143 -
Flags: review+
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #3) > Comment on attachment 8526143 [details] [diff] [review] > getSelectedEngine > > I think we should only send the identifier, I don't see any valid uses for > the name and it could be potentially confusing. I thought the name would be useful if the tour wants to expose the name of the engine to the user (instead of just using the identifier for some internal comparison)
Assignee | ||
Comment 5•10 years ago
|
||
Removed engine name and updated test
Attachment #8526143 -
Attachment is obsolete: true
Attachment #8526161 -
Flags: review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/0bcee2fc8e0b
Updated•10 years ago
|
status-firefox34:
--- → fixed
status-firefox35:
--- → affected
status-firefox36:
--- → affected
tracking-firefox34:
--- → +
tracking-firefox35:
--- → +
tracking-firefox36:
--- → +
Updated•10 years ago
|
Points: --- → 2
Flags: qe-verify?
Flags: firefox-backlog+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/10950600b75b
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/10950600b75b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Updated•10 years ago
|
Iteration: --- → 37.1
Assignee | ||
Updated•10 years ago
|
Target Milestone: Firefox 37 → Firefox 36
Assignee | ||
Comment 9•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/cf974839f00a
Comment 10•10 years ago
|
||
Verified as fixed using the following environment: FF 34 Build Id:20141125180439 OS: Win 7 x64, Mac Os X 10.9.5, Ubuntu 14.04 x64 Manual verification was possible only on FF 34 the searchbar ui tour is available.
Comment 11•10 years ago
|
||
This was already verified on Firefox 34, and I don't think it needs further verification on 35 and 36.
Flags: qe-verify? → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•