1101685 - Graphics error/warning logging - the sequel

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

We need to sort out a few things as a follow up to bug 1074952.  At least the doxygen documentation, but also whether we assert with gfxCriticalError, etc.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Maybe even log to console (e.g., LogStringMessage) for the critical errors?

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: MOZ_ASSERT with gfxCriticalError and do the doxygen documentation for the levels and preferences.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=3b2f1728766e

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Motherlode!  Critical errors during the test run:

Linux & Windows 7, dom/canvas/test/test_bug866575.html triggers http://dxr.mozilla.org/mozilla-central/source/gfx/2d/DrawTargetCairo.cpp#1488 with "Failed to create similar cairo surface! Size: Size(306368,150) Status: 32" message.

Linux & OS X 10.6 & Android 4.0, reftest/tests/image/test/crashtests/681190.html triggers: http://dxr.mozilla.org/mozilla-central/source/gfx/2d/Factory.cpp#818 with "CreateDataSourceSurfaceWithStride failed to initialize"

OS X 10.6, mochitests/content/browser/browser/base/content/test/newtab/browser_newtab_drag_drop.js triggers: http://dxr.mozilla.org/mozilla-central/source/gfx/2d/Factory.cpp#340 with "Failed to create DrawTarget, Type: 2 Size: Size(800,0)".

Windows XP & Windows 8 64-bit, reftest/tests/dom/canvas/crashtests/789933-1.html triggers: http://dxr.mozilla.org/mozilla-central/source/gfx/2d/Factory.cpp#340 with "Failed to create DrawTarget, Type: 5 Size: Size(5000,20000)"

Windows XP, reftest/tests/layout/reftests/bugs/632781-verybig.html triggers: http://dxr.mozilla.org/mozilla-central/source/gfx/2d/Factory.cpp#340 with "Failed to create DrawTarget, Type: 5 Size: Size(10000,10000)".

Windows 7, reftest/tests/dom/canvas/crashtests/780392-1.html triggers: http://dxr.mozilla.org/mozilla-central/source/gfx/2d/DrawTargetD2D.cpp#1364with "Failed to init Direct2D DrawTarget. Size: Size(10000,10000) Code: 0x80070057"

Windows 7, layout/reftests/backgrounds/vector/wide--cover--nonpercent-width-omitted-height-viewbox.html triggers: http://dxr.mozilla.org/mozilla-central/source/gfx/2d/DrawTargetD2D.cpp#1364 with "Failed to init Direct2D DrawTarget. Size: Size(768,12288) Code: 0x80070057".

Windows 8 64-bit, reftest/tests/layout/reftests/canvas/size-1.html, triggers: http://dxr.mozilla.org/mozilla-central/source/gfx/2d/Factory.cpp#340 with "Failed to create DrawTarget, Type: 7 Size: Size(100,30000)".

Comment 4

[Nicolas Silva [:nical]]

Attachment: alternative patch, conditionally assert

This patch does the same thing but makes it possible for a gfxCriticalError to not assert with a syntax like:

gfxCriticalError() << " OH NOES!"; // this will assert
gfxCriticalError(ShouldAssert(aSize)) << " OH NOES! " << aSize; // this will assert only if ShouldAssert(aSize) returns true.

It doesn't fix all of the test failures but should fix some of them.

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

I'll take a look.  Not sure about 5000, seems like 8k is a nicer number and would still fail majority of the ones above?

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Optional assert, default in critical errors. Unreasonable large textures do not assert.

Bas reviewed the doc changes in Logging.h and off-line <= change at the top of CheckSurfaceSize().

Comment 7

[Nicolas Silva [:nical]]

yeah 8k makes more sense.

Comment 8

[Milan Sreckovic [:milan] (needinfo for best results)]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5fe5cdfe989a followed by https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6b45350cf8dd

I don't think this should clash with bug 946069 in Logging.h, but I did have this one applied first if it makes a difference.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Conflicts in gfx/2d/DrawTargetCairo.cpp

Comment 10

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Optional assert, default in critical errors. Unreasonable large textures do not assert. Carry r=nical

Rebase

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b751f12a3ad

Comment 12

[Carsten Book [:Tomcat]]

sorry had to back this out for crashes on windows 7 debug like https://treeherder.mozilla.org/logviewer.html#?job_id=4717651&repo=mozilla-inbound

Comment 13

[Milan Sreckovic [:milan] (needinfo for best results)]

Thanks for the backout.  Moving target, let's see: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1cd965f29766

Comment 14

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Optional assert, default in critical errors. Unreasonable large textures do not assert. Carry r=nical

Comment 15

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Carsten Book [:Tomcat] from comment #12)
> sorry had to back this out for crashes on windows 7 debug like
> https://treeherder.mozilla.org/logviewer.html#?job_id=4717651&repo=mozilla-
> inbound

Better now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=828b1037113c

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dcd53978a8c0

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dcd53978a8c0

Comment 18

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/projects/cypress/rev/a82581055c06