Win: IME doesn't work at all on 111403 build

VERIFIED FIXED in mozilla0.9.7

Status

()

Core
Internationalization
--
critical
VERIFIED FIXED
16 years ago
7 years ago

People

(Reporter: Masaki Katakai, Assigned: Roy Yokoyama)

Tracking

(4 keywords)

Trunk
mozilla0.9.7
x86
Windows 2000
inputmethod, intl, regression, smoketest
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
I tried today's nightly of 111403 and found Japanese IME (MSIME on
Win2K) doesn't work at all. Now sure which check-in causes this problem,
but I verified 1113 nightly worked well.
(Reporter)

Comment 1

16 years ago
Sorry,

"Now sure" -> "*Not* sure"

Comment 2

16 years ago
Changing severity to blocker.

Does the fix for bug 107494 cause this bug?
Severity: normal → blocker

Comment 3

16 years ago
I could reproduce this with 111403 trunk build on Win2k-J.  

Yoying, could you reproduce this on other Windows?
Keywords: intl
QA Contact: teruko → ylong

Updated

16 years ago
Keywords: nsbeta1, regression

Comment 4

16 years ago
WinME-Ja has same result.

Linux and Mac OS 10.1 work fine though.
(Assignee)

Comment 5

16 years ago
I have 11/13 trunk build and I see the same problem.
My local tree doesn't have the patch for bug 107494.
Does 11/13 works for you guys?

Status: NEW → ASSIGNED
(Reporter)

Comment 6

16 years ago
On my Win2K, 2001111303 build works fine.

Comment 7

16 years ago
I don't think my patch to bug 107494 could cause this.  Nonetheless, Roy let me
know if you need me to come down and look at this with you.  

Comment 8

16 years ago
seen on windows commercial build 2001-11-15-05-trunk

reinstalling yesterdays smoketest build to confirm that I hadn't seen it 
yesterday per Roy's request.
Keywords: smoketest
(Assignee)

Comment 9

16 years ago
I am on it.
(Assignee)

Comment 10

16 years ago
IME Composition handling is done in widget\src\windows\nsWindow.cpp.
There was a check-in on 11/14/2001 04:35

ccing  jaggernaut@netscape.com
(Assignee)

Comment 11

16 years ago
Returned string 'mIMECompUnicode' from NS_IMM_GETCOMPOSITIONSTRINGW() is empty.
5188 NS_IMM_GETCOMPOSITIONSTRINGW(hIMEContext,
5189      GCS_COMPSTR,
5190      (LPVOID)mIMECompUnicode->get(),
5191       compStrLen, compStrLen);
http://lxr.mozilla.org/seamonkey/source/widget/src/windows/nsWindow.cpp#5190

When I give a WCHAR string to NS_IMM_GETCOMPOSITIONSTRINGW(),  it contains 
a correct text.

jag: How does nsString change affect this?


Comment 12

16 years ago
ack, there was a typo.. I think that 2nd compStrLen should be compStrLen+1.. 
can you try that and see if it helps?

Comment 13

16 years ago
what used to happen before is that we'd call SetCapacity() and then look at the 
capacity member to see what our actual capacity is. mCapacity is now private, 
so we have to just assume that we got the minimum capacity. Unfortunately, we 
were off by one in the patch.

Comment 14

16 years ago
yokoyama is working on this one.  Sheriff agreed to downgrade this bug.

Loan
Severity: blocker → critical
(Assignee)

Comment 15

16 years ago
Created attachment 58024 [details] [diff] [review]
missed by one byte and use of buflen

Found two problem.
1) as jag comments, we were off by one
2) we shouldn't use compStrLen in NS_IMM_GETCOMPOSITIONSTRING() as in and
   out param.  NS_IMM_GETCOMPOSITIONSTRING macro always set out param to 0

ftang: can you review?
(Assignee)

Comment 16

16 years ago
Comment on attachment 58024 [details] [diff] [review]
missed by one byte and use of buflen

got /r=ftang.
Attachment #58024 - Flags: review+
(Assignee)

Comment 17

16 years ago
alecf,jag: can you /sr=?

Comment 18

16 years ago
Comment on attachment 58024 [details] [diff] [review]
missed by one byte and use of buflen

sr=alecf
Attachment #58024 - Flags: superreview+
(Assignee)

Comment 19

16 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla0.9.7
verified on windows commercial build 2001-11-16-05-trunk
Status: RESOLVED → VERIFIED
Keywords: inputmethod
You need to log in before you can comment on or make changes to this bug.