Closed
Bug 1101742
Opened 11 years ago
Closed 11 years ago
OmxDecoder::mIsVideoSeeking becomes false during video seeking
Categories
(Core :: Audio/Video, defect)
Tracking
()
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
(Keywords: branch-patch-needed, regression)
Attachments
(2 files)
|
1.56 KB,
patch
|
cajbir
:
review+
bajaj
:
approval-mozilla-b2g32+
bajaj
:
approval-mozilla-b2g34+
|
Details | Diff | Splinter Review |
|
1.57 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1099356 +++
During video seeking in OmxDecoder::ReadVideo(), OmxDecoder::mIsVideoSeeking could become false. It should be true.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
This bug is a regression of Bug 1059661.
Blocks: 1059661
Keywords: regression
|
|
Assignee | |
Updated•11 years ago
|
status-b2g-v2.0:
--- → affected
status-b2g-v2.0M:
--- → affected
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → affected
|
|
Assignee | |
Comment 3•11 years ago
|
||
[Blocking Requested - why for this release]: This bug is a regression of b2gv2.0+ bug(Bug 1059661). This bug cause a crash during video seeking.
blocking-b2g: --- → 2.0?
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8525485 -
Flags: review?(cajbir.bugzilla)
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Updated•11 years ago
|
Attachment #8525485 -
Flags: review?(cajbir.bugzilla) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
||
Updated•11 years ago
|
blocking-b2g: 2.0? → 2.0+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
|
|
Assignee | |
Comment 7•11 years ago
|
||
Comment on attachment 8525485 [details] [diff] [review]
patch - Fix OmxDecoder::mIsVideoSeeking
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 1059661
User impact if declined: application could crash during seeking video.
Testing completed: locally tested.
Risk to taking this patch (and alternatives if risky): low risk.
String or UUID changes made by this patch: none.
Attachment #8525485 -
Flags: approval-mozilla-b2g34?
Attachment #8525485 -
Flags: approval-mozilla-b2g32?
|
|
||
Updated•11 years ago
|
Attachment #8525485 -
Flags: approval-mozilla-b2g34?
Attachment #8525485 -
Flags: approval-mozilla-b2g34+
Attachment #8525485 -
Flags: approval-mozilla-b2g32?
Attachment #8525485 -
Flags: approval-mozilla-b2g32+
|
|
||
Updated•11 years ago
|
I'm trying to land this on b2g34 and b2g32, but the /dom/media/omx/ directory doesn't seem to exist on these branches. Do we need branch patches for this, or do we not even need this on b2g32/34?
Flags: needinfo?(sotaro.ikeda.g)
Keywords: branch-patch-needed
|
|
Assignee | |
Comment 9•11 years ago
|
||
(In reply to Wes Kocher (:KWierso) from comment #8)
> I'm trying to land this on b2g34 and b2g32, but the /dom/media/omx/
> directory doesn't seem to exist on these branches. Do we need branch patches
> for this, or do we not even need this on b2g32/34?
This folder is recently move from /content/media/omx.
Flags: needinfo?(sotaro.ikeda.g)
|
|
Assignee | |
Comment 10•11 years ago
|
||
Attachment #8527058 -
Flags: review+
|
|
Assignee | |
Comment 11•11 years ago
|
||
KWierso, I created a patch for b2g v2.1. It should work also for b2g v2.0.
Flags: needinfo?(kwierso)
|
||
Comment 13•11 years ago
|
||
|
||
Comment 14•11 years ago
|
||
Backed out from b2g32 for crashes/asserts.
https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/1fe4a4194576
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=62234&repo=mozilla-b2g32_v2_0
Flags: needinfo?(sotaro.ikeda.g)
|
|
||
Comment 15•11 years ago
|
||
Sorry, wrong bug. Re-landed.
https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/2ebc5da2c844
|
|
||
Updated•11 years ago
|
Flags: needinfo?(sotaro.ikeda.g)
You need to log in
before you can comment on or make changes to this bug.
Description
•