Closed Bug 1101760 Opened 10 years ago Closed 9 years ago

Figure out what "unpin all" should do.

Categories

(Tree Management :: Treeherder, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: KWierso, Assigned: jfrench)

Details

Attachments

(1 file)

At the moment, clicking "Unpin all" clears the pinboard of all jobs and clears the "related bugs" section, but leaves the classification type field at whatever it has been changed to and leaves whatever text is typed into the classification textarea alone.

I'd argue that this should be either an all or nothing type of thing. It should either only clear the pinboard (since that's all "Unpin all" would seem to indicate), or it should clear everything (and maybe need a string change to "Reset pinboard"), so that the pinboard is empty, related bugs is empty, the type resets to "intermittent", and the textarea is empty.
+1 to clearing everything, though it'd be nice if it wasn't right underneath the save button at that point. I know I've accidentally clicked the wrong button before and would be annoyed to have to re-do everything in that circumstance :)
Makes sense. I'd pose 'Un-pin all' could be renamed to 'Clear', made a smaller UI target and perhaps not near the Save button. Since its behavior is mildly destructive.

Hopefully the work in bug 1030686 which intends to add ctrl+enter for Save, will mitigate the UX also.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
I've got this done, so I am going to put this up as a quick PR shortly, independent of 1107136.

Eventually we should be able re-arrange the existing clear/save/menu cluster, as a row below the (upcoming smaller) comment input field, since there will be space there, which will save more space.

Accidental un-pin-all/clear should also be mitigated by 1107136, assuming the Sheriffs are heavily into shortcuts.
Attached file treeherder-ui-PR#308
Please see above PR for review and status.
Attachment #8538284 - Flags: review?(cdawson)
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/b905c393308dedadf050124dde5e213fe0bae342
Bug 1101760 - Clear classification fully on an unpin all

https://github.com/mozilla/treeherder-ui/commit/839247f6b16fa5dbc7dbfc6b586d19301e6af34a
Merge pull request #308 from tojonmz/clear-classification

Bug 1101760 - Clear classification fully on an unpin all
Attachment #8538284 - Flags: review?(cdawson) → review+
Marking Fixed, will verify once it's on stage or production.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified fixed on production.
Status: RESOLVED → VERIFIED
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/832cf643c5457655e8eed167ab690eedbbcc35f5
Bug 1101760 - Clear classification fully on an unpin all

https://github.com/mozilla/treeherder/commit/eab7981024f46ba8b414ddfe03c5a0f836f1680f
Merge pull request #308 from tojonmz/clear-classification

Bug 1101760 - Clear classification fully on an unpin all
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: