Closed
Bug 1101770
Opened 10 years ago
Closed 9 years ago
[steeplechase] add over all timeout
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: drno, Assigned: drno)
Details
Attachments
(1 file)
2.05 KB,
patch
|
sydpolk
:
review+
|
Details | Diff | Splinter Review |
As the 300s timeout for mochitest does not work if tests get executed in steeplechase we need another high level timeout to prevent the test machines getting filled/blocked with open browser windows in case a test fails.
Assignee | ||
Comment 1•10 years ago
|
||
This adds one high level timer in case a test gets executed in steeplechase which exits the whole test if it has not finished by then. Try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=19ef23fc91e1
Attachment #8525591 -
Flags: review?(spolk)
Comment 2•10 years ago
|
||
Comment on attachment 8525591 [details] [diff] [review] bug_1101770_add_steeplechase_timeout.patch Review of attachment 8525591 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, as long as the timeout is 30s and not 300s.
Attachment #8525591 -
Flags: review?(spolk) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Manually double checked it is 30s. BTW I ran this with an artificial error in our lab and it was exiting the hanging browser (and the other side gave up).
Assignee | ||
Comment 4•10 years ago
|
||
Try run looks green, besides some unrelated oranges.
Keywords: checkin-needed
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c7a7f4ca6ce
Keywords: checkin-needed
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9c7a7f4ca6ce
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•