1101778 - Change footer link hover to a lighter color

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Mikhail]

Attachment: bottom of page accesability problem.jpg

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141106120505

Steps to reproduce:

go to https://mozillians-dev.allizom.org
sroll to the bottom of page
see the text color and background


Actual results:

When mouse goes on "blue colored" link, it becomes "dark blue". It's hard to read "dark blue" text on grey background.


Expected results:

May be change active link color to this color (light blue)? See "bottom of page accesability problem.jpg" attached screenshot

Comment 1

[William Reynolds [:williamr]]

Thanks for filing this bug, Mikhail!

As suggested in comment 0, let's use a light blue link color when hovering over a link in the footer instead of the current dark blue.

Comment 2

[Utkarsh Bansal]

Hey i would like to fix this bug. But I am new here so i would need help getting started.

Comment 3

[William Reynolds [:williamr]]

Nemo, can you help Mikhail get started?

Comment 4

[Mikhail]

Umm... 
(In reply to William Reynolds [:williamr] from comment #3)
> Nemo, can you help Mikhail get started?

well, actually bansalutkarsh3 was the one who want to fix this bug. Not me =)

Comment 5

[Nikos Roussos [:comzeradd]]

(In reply to bansalutkarsh3 from comment #2)
> Hey i would like to fix this bug. But I am new here so i would need help
> getting started.

Hi bansalutkarsh3,

This is great. First step is to setup your local development environment. Start my forking the repository to your personal github account and then follow the instructions from the documentation:
http://mozillians.readthedocs.org/en/latest/installation/installation-virtualenv.html

If you are on Linux you may alternatively look the Docker guide, which should be easier:
http://mozillians.readthedocs.org/en/latest/installation/installation-docker.html

Comment 6

[Giovanny Gongora [:gioyik]]

Attachment: Github PR

Comment 7

[Giovanny Gongora [:gioyik]]

Hi,

I created a PR with a patch for this. Could be reviewed? I am not sure if it is the correct file, so let me know if it needs a change.

Thanks

Comment 8

[Giovanny Gongora [:gioyik]]

William could you check the PR? Seems that Nikos is offline since a time.

Thanks

Comment 9

[William Reynolds [:williamr]]

(In reply to Giovanny Gongora [:gioyik] from comment #8)
> William could you check the PR? Seems that Nikos is offline since a time.

Thanks for creating a PR, Giovanny! I will defer to Nikos or Nemo to review your PR since I don't currently have a dev environment set up to test your PR.

Comment 10

[Giovanny Gongora [:gioyik]]

Thank you

Comment 11

[Nikos Roussos [:comzeradd]]

Hi Giovanny,

Sorry for the delay. Fosdem traveling hold me back :)

PR looks good. I'll merge it asap.

Comment 12

[Giovanny Gongora [:gioyik]]

Don't worry. Take you time :)

Comment 13

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/d62ae288bdcd88124ee23b4746ae7dd91c3eac1e
[Fix bug 1101778] Change footer link hover to a lighter color.

https://github.com/mozilla/mozillians/commit/229fbb1b2e57b91c695a178d21effbf4e5f819b9
Merge pull request #1158 from johngian/pr1153

[Fix bug 1101778] Change footer link hover to a lighter color.

Comment 14

[John Giannelos [:nemo-yiannis]]

Verified on stage:

* Footer links has a lighter colour on hover.