Closed Bug 1101784 Opened 5 years ago Closed 5 years ago

Don't clip to padding in tabs panel grid

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 36

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(1 file)

Otherwise the grid scrolls into 'nowhere'.
Attachment #8525532 - Flags: review?(michael.l.comella)
Comment on attachment 8525532 [details] [diff] [review]
Don't clip to padding in tabs panel grid (r=mcomella)

Review of attachment 8525532 [details] [diff] [review]:
-----------------------------------------------------------------

Works, but this should probably be in styles.xml (Widget.TabsGridLayout [1]).

(In reply to Lucas Rocha (:lucasr) from comment #0)
> Otherwise the grid scrolls into 'nowhere'.

What do you mean by this? The grid doesn't touch the bottom of the screen?

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/values/styles.xml?rev=597441df1450#197
Attachment #8525532 - Flags: review?(michael.l.comella) → review+
(In reply to Michael Comella (:mcomella) from comment #2)
> Comment on attachment 8525532 [details] [diff] [review]
> Don't clip to padding in tabs panel grid (r=mcomella)
> 
> Review of attachment 8525532 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Works, but this should probably be in styles.xml (Widget.TabsGridLayout [1]).

Good point, done.

> (In reply to Lucas Rocha (:lucasr) from comment #0)
> > Otherwise the grid scrolls into 'nowhere'.
> 
> What do you mean by this? The grid doesn't touch the bottom of the screen?

Have a look at this: https://plus.google.com/+AndroidDevelopers/posts/LpAA7q4jw9M

> [1]:
> https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/
> values/styles.xml?rev=597441df1450#197
https://hg.mozilla.org/mozilla-central/rev/bcc4c4f72361
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
You need to log in before you can comment on or make changes to this bug.