Closed
Bug 1101820
Opened 10 years ago
Closed 10 years ago
Change 'Sign in with Persona' from a link to a button for accessibility
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ricardo, Assigned: ricardo)
References
Details
(Whiteboard: [accessibility][nov28][login])
Attachments
(1 file)
Tricky and meticulous CSS changes are needed so that stuff doesn't break.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8525601 -
Flags: review?(cade)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Updated•10 years ago
|
Attachment #8525601 -
Flags: review?(cade) → review+
Comment 2•10 years ago
|
||
Comment on attachment 8525601 [details] [review] https://github.com/mozilla/webmaker-login-ux/pull/79 I lied
Attachment #8525601 -
Flags: review+ → review-
Comment 3•10 years ago
|
||
The plainjs adapter needs a selector update for the ng-click directive setup. https://github.com/mozilla/webmaker-login-ux/blob/cd6943b937f1080235897caacdd14d4816895fc9/src/adapters/plain.js#L443
Assignee | ||
Updated•10 years ago
|
Attachment #8525601 -
Flags: review- → review?(cade)
Comment 4•10 years ago
|
||
Comment on attachment 8525601 [details] [review] https://github.com/mozilla/webmaker-login-ux/pull/79 still need that plainjs adapter update.
Attachment #8525601 -
Flags: review?(cade) → review-
Updated•10 years ago
|
Attachment #8525601 -
Flags: review- → review+
Comment 5•10 years ago
|
||
Comment on attachment 8525601 [details] [review] https://github.com/mozilla/webmaker-login-ux/pull/79 I'm such a derp. wrong bug
Attachment #8525601 -
Flags: review+ → review-
Assignee | ||
Updated•10 years ago
|
Attachment #8525601 -
Flags: review- → review?(cade)
Assignee | ||
Comment 6•10 years ago
|
||
Good catch. Updated plain js adapter.
Updated•10 years ago
|
Attachment #8525601 -
Flags: review?(cade) → review+
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•