Change 'Sign in with Persona' from a link to a button for accessibility

RESOLVED FIXED

Status

Webmaker
webmaker.org
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ricardo, Assigned: ricardo)

Tracking

Details

(Whiteboard: [accessibility][nov28][login])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Tricky and meticulous CSS changes are needed so that stuff doesn't break.
(Assignee)

Comment 1

3 years ago
Created attachment 8525601 [details] [review]
https://github.com/mozilla/webmaker-login-ux/pull/79
Attachment #8525601 - Flags: review?(cade)
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED

Updated

3 years ago
Attachment #8525601 - Flags: review?(cade) → review+
Comment on attachment 8525601 [details] [review]
https://github.com/mozilla/webmaker-login-ux/pull/79

I lied
Attachment #8525601 - Flags: review+ → review-
The plainjs adapter needs a selector update for the ng-click directive setup.

https://github.com/mozilla/webmaker-login-ux/blob/cd6943b937f1080235897caacdd14d4816895fc9/src/adapters/plain.js#L443
(Assignee)

Updated

3 years ago
Attachment #8525601 - Flags: review- → review?(cade)
Comment on attachment 8525601 [details] [review]
https://github.com/mozilla/webmaker-login-ux/pull/79

still need that plainjs adapter update.
Attachment #8525601 - Flags: review?(cade) → review-

Updated

3 years ago
Attachment #8525601 - Flags: review- → review+
Comment on attachment 8525601 [details] [review]
https://github.com/mozilla/webmaker-login-ux/pull/79

I'm such a derp. wrong bug
Attachment #8525601 - Flags: review+ → review-
(Assignee)

Updated

3 years ago
Attachment #8525601 - Flags: review- → review?(cade)
(Assignee)

Comment 6

3 years ago
Good catch. Updated plain js adapter.

Updated

3 years ago
Attachment #8525601 - Flags: review?(cade) → review+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.