bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

"Rows per page" to "Pictures per page"

RESOLVED FIXED

Status

Webtools
Air Mozilla
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: peterbe, Assigned: Anurag Chaudhury)

Tracking

Trunk
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug], URL)

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Created attachment 8525611 [details]
Screenshot 2014-11-19 14.39.00.png

On the Picture Gallery view (in management) there's a widget at the bottom that says "Rows per page" but what you're selecting is how many pictures per page.
(Reporter)

Updated

4 years ago
Whiteboard: [good first bug]
(Assignee)

Comment 1

4 years ago
Hi Peter,

I made the change and committed the changes. However, I accidentally made the commit into the existing pull request

https://github.com/mozilla/airmozilla/pull/127

Sorry about that. I'll be more careful next time so as to issue a new pull request.

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Updated

4 years ago
Assignee: nobody → anuragchaudhury
(Reporter)

Comment 3

4 years ago
We changed it so that it affects all places where that snippet is used. On the Picture Gallery we need it to say "Pictures per page" on the Event Manager it needs to say "Rows per page".
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

4 years ago
Hey Peter, but they both use _angular_pagesize, so should we add in a function which depending on the parameter passed produces the label as "Rows per page" or "Pictures per page"?
(Reporter)

Comment 5

4 years ago
(In reply to Anurag Chaudhury from comment #4)
> Hey Peter, but they both use _angular_pagesize, so should we add in a
> function which depending on the parameter passed produces the label as "Rows
> per page" or "Pictures per page"?

Yeah, we'll using a trick to set an exception outside the inclusion of _angular_pagesize. I actually already have a solution in place. Just haven't merged it yet.
(Assignee)

Comment 6

4 years ago
(In reply to Peter Bengtsson [:peterbe] from comment #5)
> (In reply to Anurag Chaudhury from comment #4)
> > Hey Peter, but they both use _angular_pagesize, so should we add in a
> > function which depending on the parameter passed produces the label as "Rows
> > per page" or "Pictures per page"?
> 
> Yeah, we'll using a trick to set an exception outside the inclusion of
> _angular_pagesize. I actually already have a solution in place. Just haven't
> merged it yet.

Oh, I see. In that case, I won't start working on it.

Updated

4 years ago
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.