110190 - Mac: can't type in plugins (no keyboard events)

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[Benjamin Mucci]

BuildID:    2001110404

Go to any page with a quicktime movie (Any trailer on http://www.apple.com/
trailers/ for exemple). Try to use the space bar (start / pause) or arrows to 
control the movie frame by frame as in NN4.7 -> Impossible.

Reproducible: Always

Comment 1

[Matthias Versen [:Matti]]

-> Plugins

Comment 2

[av (gone)]

This works on Windows. -->Peter.

Comment 3

[Peter Lubczynski]

Confirming on OS 9. The spacebar does not stop/start the movie as it does in IE.

How about OSX?

Comment 4

[shrirang khanzode]

same on os x.

Comment 5

[Peter Lubczynski]

Thanks!

Comment 6

[Peter Lubczynski]

*** Bug 110194 has been marked as a duplicate of this bug. ***

Comment 7

[Benjamin Mucci]

It works now. 2001121908 MacOS 8.6

Play / Pause / Fwd / Rwd / Volume + / -

Comment 8

[Joel Chan]

Sorry, this still doesn't work with today's (2001-12-20-04) builds on MacOS 9.2.2.

More importantly, this bug is preventing users from playing Shockwave/Flash
games since the bug is not restricted to the QuickTime plugin (see bug 110194).
 Perhaps severity should be upgraded to major or even critical.

Comment 9

[Benjamin Mucci]

Joel can you try on this URL:
http://www.apple.com/games/trailers/monsters/index.html

Everything works here. MacOS 8.6 Build 2001122004

Comment 10

[shrirang khanzode]

done: critical

Comment 11

[Joel Chan]

Thanks, Shrirang.

No, sorry Benjamin, the space bar does nothing when playing any of the trailers
on my machine.  It works fine in Netscape 6.2.1.

Comment 12

[Peter Lubczynski]

This is probably also blocking bug 116392, for windowless plugins. 

Comment 13

[Peter Lubczynski]

Attachment: mac fix

I think something changed. It looked like we used to get KeyDown and KeyUp
events but for some reason it's now changed to KeyPress and KeyUp. This patch
fixes the dispatch for KeyPress events.

Comment 14

[av (gone)]

Comment on attachment 62604 [details] [diff] [review]
mac fix

r=av

Comment 15

[Peter Lubczynski]

*** This bug has been marked as a duplicate of 116392 ***

Comment 16

[Joel Chan]

I'm not sure whether to report it here or with bug 116392, but it seems that
this bug has reappeared on MacOS 9.2.1, buildID 2002-02-15-08.

At http://www.apple.com/trailers/ watch any of the trailers and hit space bar;
nothing happens.

Comment 17

[Peter Lubczynski]

reopening

Comment 18

[Brian Nesse (gone)]

Broken on OS X as well.

Comment 19

[Peter Lubczynski]

Attachment: updated mac fix

Please review

Comment 20

[Steve Dagley]

Comment on attachment 70385 [details] [diff] [review]
updated mac fix

r=sdagley

Comment 21

[Patrick C. Beard]

Comment on attachment 70385 [details] [diff] [review]
updated mac fix

sr=beard

Comment 22

[Peter Lubczynski]

patch in trunk, marking FIXED

Comment 23

[shrirang khanzode]

verified that typing works on mac 9.2.1 and OS X.1 trunk (0220).
Also verified that quicktime movies can be controlled with keyboard(spacebar and 
arrow buttons).

However, noticed one thing *only* on OS X.1: When I click inside a movie when it 
launches, and hit the spacebar...things work as intended ( movie pauses/plays).
Now, if I minimize the browser window and maximize it again and click inside the 
quicktime movie to get focus and hit spacebar....nothing happens...arrow buttons 
do not work either. Can anyone confirm this..or is this just me? 

Comment 24

[Benjamin Mucci]

Shri you are right,

The spacebar doesn't work here. To stop the QT I must hold for a while the
spacebar and it's only works 50% of the time. It's the same thing to restart the QT.

Also if the QT is paused the arrows don't work but they work while the QT play.

reopen

The test page used:
http://www.apple.com/hardware/ads/newimac_superdrive_320.html

Comment 25

[Benjamin Mucci]

Sorry. MacOS 8.6 - Build 2002022003

Comment 26

[shrirang khanzode]

Peter just pointed out, bug 124929 handles this issue. 
This happens on pages without plugins as well.
So this bug is completely fixed. marking fixed and verified ...

Comment 27

[shrirang khanzode]

v