1101942 - Cannot create gaia profile using local b2g-sdk downloaded from ftp.mozilla.org

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Greg Arndt [:garndt]]

Make script exists with an error when attempting to create a profile using a local b2g-sdk along with the option "USE_LOCAL_XULRUNNER_SDK" when the package was downloaded from the ftp site [1].  Looks like the path used to determine where xpcshell resides doesn't include the path that's found in the nightly archive.  This package does work fine when not using the "USE_LOCAL_XULRUNNER_SDK" option.

Example:
make USE_LOCAL_XULRUNNER_SDK=1 XULRUNNER_DIRECTORY=../xulsdk/ DESKTOP=0 DESKTOP_SHIMS=0 DEBUG=0 NOFTU=0

[1] http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-b2g34_v2_1/b2g-34.0a2.multi.linux-x86_64.tar.bz2

Comment 1

[Greg Arndt [:garndt]]

Attachment: GH PR 26311

Added another search path for xpcshell that will match the patch found in the nightly b2gsdk build on ftp.mozilla.org

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8525696 [details] [review]
GH PR 26311

We will get a b2g/ folder after extracting nightly archive. So I think it makes sense to point $(XULRUNNER_DIRECTORY)/b2g/xpcshell rather than $(XULRUNNER_DIRECTORY)/bin/xpcshell.

But I really want to know why we put $(XULRUNNER_DIRECTORY)/bin/xpcshell in Makefile. Maybe there are some retional reasons. We should ni Martin Thomson to make sure that.

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Before XUL is replaced by b2g, we assume that the path of xpcshell points to bin/xpcshell. After changing to b2g, the xpcshell is moved to b2g/xpcshell, so I think it is possible a bug which we forgot to modify bin/ to b2g/.

Comment 4

[Greg Arndt [:garndt]]

:rickychien thanks.  Should I modify the Makefile or keep it as is?  Just wondering where this stands and what I could do to help it along.  Thanks!

Comment 5

[Martin Thomson [:mt:]]

Comment on attachment 8525696 [details] [review]
GH PR 26311

r+ conditional on addressing the comment in the PR.

Comment 6

[Ricky Chien [:rickychien] (inactive)]

@Greg Arndt, I'm not sure about your question. Just modify Makefile as Martin's comment on Github and merge your pull request.

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Nice Job! Greg Arndt.

Merged.

https://github.com/mozilla-b2g/gaia/commit/1edb41b5de2d0dac9a12872bd4132f618faf1195

Comment 8

[Carsten Book [:Tomcat]]

reverted for causing bustage like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=888055&repo=b2g-inbound

Comment 9

[Greg Arndt [:garndt]]

Pushed to try using my gaia fork/branch that contains this change:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d44993945b78

I also looked at the build logs and where it would have affected it is identical both in a failed build job and a passing one.  Was another bug determined to be the cause of this backout?  What can I do to ensure that this is good enough to land again?

Comment 10

[Greg Arndt [:garndt]]

Actually, disregard, it looks like the branch I used was rebased and contained the backed out commit as well.  Will try again and report the results.

Comment 11

[Ricky Chien [:rickychien] (inactive)]

Confirm bustage is caused by bug 1103819. I'm going to land it again soon.

Comment 12

[Ricky Chien [:rickychien] (inactive)]

Merged.

https://github.com/mozilla-b2g/gaia/commit/f178871acd5b5cce0cb10ca51500462279b09f46