Closed
Bug 110195
Opened 23 years ago
Closed 23 years ago
master passwords steals focus in prefs
Categories
(SeaMonkey :: Preferences, defect)
SeaMonkey
Preferences
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: en.mozilla, Assigned: KaiE)
References
Details
(Whiteboard: [adt2 rtm] fixed on trunk)
Attachments
(1 file, 1 obsolete file)
2.61 KB,
patch
|
ssaux
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
Setup:
choose the "if it hasn't been used for X minutes" option in master password prefs
Repro:
1) open preferences
2) expand "Privacy & Security"
3) select "Master Passwords"
Expected: category list keeps focus
Actual: the textbox for minutes steals focus
I use keyboard navigation inside prefs, so down-arrow doesn't work for me to
move to SSL sub-category if Master Passwords renders.
Confirmed in W2k and Linux with build 2001-11-14
The OnCheck handler for the radio button probably sets focus to the minutes edit box
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Hardware: PC → All
Comment 2•23 years ago
|
||
erik, does this happen on only that pref panel, or others?
bryner/samir, would this be a more general focus issue, or should this go over
to the psm folx?
Comment 3•23 years ago
|
||
really cc'ing bryner...
Comment 4•23 years ago
|
||
-> javi
Looked at the panel initialization code which is setting the value of the text
field and gaining focus as a side-effect.
Assignee: sgehani → javi
Comment 5•23 years ago
|
||
testing this out... the "If it had not bee used in [n] minutes" radiobutton
needs to be selected in order to see this.
QA Contact: sairuh → junruh
Comment 6•23 years ago
|
||
cc'ing ssaux
Comment 7•23 years ago
|
||
pref-masterpass.js sets the focus in changePasswordSettings(). This function is
called from the oncommand handler for the radio buttons in pref-masterpass.xul,
but also from the onLoad handler. It probably would be enough to not set the
focus when changedPasswordSettings() is called from the onload handler.
I'll put it on my plate to test that.
Comment 8•23 years ago
|
||
Set focus to the text field only when appropriate.
Comment 9•23 years ago
|
||
kai (or javi) can you review.
Assignee | ||
Comment 10•23 years ago
|
||
Comment on attachment 64448 [details] [diff] [review]
proposed patch
Patch looks good to me, just one nit-pick: When you type inside the
passwordTimeout field, the field should already have focus. Therefore, it's not
required the set focus to the field again. I suggest to use parameter
setfocus=false in the last call in your patch.
r=kaie
Attachment #64448 -
Flags: review+
Comment 11•23 years ago
|
||
Incorporate changes suggested by Kai.
Attachment #64448 -
Attachment is obsolete: true
Comment 12•23 years ago
|
||
Comment on attachment 64618 [details] [diff] [review]
updated path
move has-review from previous patch to this one as per Kai's implicit approval.
Attachment #64618 -
Flags: review+
Updated•23 years ago
|
Comment 13•23 years ago
|
||
who should super-review this?
Updated•23 years ago
|
Attachment #64618 -
Flags: superreview+
Comment 16•23 years ago
|
||
Comment on attachment 64618 [details] [diff] [review]
updated path
sr=alecf
Assignee | ||
Comment 17•23 years ago
|
||
Stephane, as you produced the patch, do you want to check it in?
Let me know if I should do it.
Assignee | ||
Comment 18•23 years ago
|
||
taking
Assignee | ||
Comment 19•23 years ago
|
||
Checked in to trunk.
Comment 20•23 years ago
|
||
Verified on the 5/29 Win2000 trunk.
Assignee | ||
Updated•23 years ago
|
Comment 21•23 years ago
|
||
adt1.0.1- per ADT triage, for the follwoing reasons.
1. The pref that has this problem isn't the default selection.
2. My guess is this panel isn't being accessed too often by people not working
on the feature.
3. It has an easy workaround - you can tab pretty quickly back to the tree of
panels.
Comment 22•23 years ago
|
||
Verified.
Status: RESOLVED → VERIFIED
Whiteboard: [adt2 rtm] → [adt2 rtm] fixed on trunk
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•