Setup: choose the "if it hasn't been used for X minutes" option in master password prefs Repro: 1) open preferences 2) expand "Privacy & Security" 3) select "Master Passwords" Expected: category list keeps focus Actual: the textbox for minutes steals focus I use keyboard navigation inside prefs, so down-arrow doesn't work for me to move to SSL sub-category if Master Passwords renders.
Confirmed in W2k and Linux with build 2001-11-14 The OnCheck handler for the radio button probably sets focus to the minutes edit box
erik, does this happen on only that pref panel, or others? bryner/samir, would this be a more general focus issue, or should this go over to the psm folx?
really cc'ing bryner...
-> javi Looked at the panel initialization code which is setting the value of the text field and gaining focus as a side-effect.
testing this out... the "If it had not bee used in [n] minutes" radiobutton needs to be selected in order to see this.
pref-masterpass.js sets the focus in changePasswordSettings(). This function is called from the oncommand handler for the radio buttons in pref-masterpass.xul, but also from the onLoad handler. It probably would be enough to not set the focus when changedPasswordSettings() is called from the onload handler. I'll put it on my plate to test that.
Created attachment 64448 [details] [diff] [review] proposed patch Set focus to the text field only when appropriate.
kai (or javi) can you review.
Comment on attachment 64448 [details] [diff] [review] proposed patch Patch looks good to me, just one nit-pick: When you type inside the passwordTimeout field, the field should already have focus. Therefore, it's not required the set focus to the field again. I suggest to use parameter setfocus=false in the last call in your patch. r=kaie
Created attachment 64618 [details] [diff] [review] updated path Incorporate changes suggested by Kai.
Comment on attachment 64618 [details] [diff] [review] updated path move has-review from previous patch to this one as per Kai's implicit approval.
who should super-review this?
Stephane, as you produced the patch, do you want to check it in? Let me know if I should do it.
Checked in to trunk.
Verified on the 5/29 Win2000 trunk.
adt1.0.1- per ADT triage, for the follwoing reasons. 1. The pref that has this problem isn't the default selection. 2. My guess is this panel isn't being accessed too often by people not working on the feature. 3. It has an easy workaround - you can tab pretty quickly back to the tree of panels.