master passwords steals focus in prefs

VERIFIED FIXED

Status

SeaMonkey
Preferences
--
minor
VERIFIED FIXED
16 years ago
10 years ago

People

(Reporter: Erik Neuenschwander, Assigned: kaie)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [adt2 rtm] fixed on trunk)

Attachments

(1 attachment, 1 obsolete attachment)

2.61 KB, patch
Stephane Saux
: review+
Alec Flett
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
Setup:
choose the "if it hasn't been used for X minutes" option in master password prefs

Repro:
1) open preferences
2) expand "Privacy & Security"
3) select "Master Passwords"

Expected: category list keeps focus
Actual: the textbox for minutes steals focus

I use keyboard navigation inside prefs, so down-arrow doesn't work for me to
move to SSL sub-category if Master Passwords renders.

Comment 1

16 years ago
Confirmed in W2k and Linux with build 2001-11-14
The OnCheck handler for the radio button probably sets focus to the minutes edit box
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Hardware: PC → All
erik, does this happen on only that pref panel, or others?

bryner/samir, would this be a more general focus issue, or should this go over
to the psm folx?
really cc'ing bryner...

Comment 4

16 years ago
-> javi

Looked at the panel initialization code which is setting the value of the text
field and gaining focus as a side-effect.
Assignee: sgehani → javi
testing this out... the "If it had not bee used in [n] minutes" radiobutton
needs to be selected in order to see this.
QA Contact: sairuh → junruh

Comment 6

16 years ago
cc'ing ssaux

Comment 7

16 years ago
pref-masterpass.js sets the focus in changePasswordSettings(). This function is
called from the oncommand handler for the radio buttons in pref-masterpass.xul,
but also from the onLoad handler.  It probably would be enough to not set the
focus when changedPasswordSettings() is called from the onload handler.

I'll put it on my plate to test that.

Comment 8

16 years ago
Created attachment 64448 [details] [diff] [review]
proposed patch

Set focus to the text field only when appropriate.

Comment 9

16 years ago
kai (or javi) can you review.
(Assignee)

Comment 10

16 years ago
Comment on attachment 64448 [details] [diff] [review]
proposed patch

Patch looks good to me, just one nit-pick: When you type inside the
passwordTimeout field, the field should already have focus. Therefore, it's not
required the set focus to the field again. I suggest to use parameter
setfocus=false	in the last call in your patch.
r=kaie
Attachment #64448 - Flags: review+

Comment 11

16 years ago
Created attachment 64618 [details] [diff] [review]
updated path

Incorporate changes suggested by Kai.
Attachment #64448 - Attachment is obsolete: true

Comment 12

16 years ago
Comment on attachment 64618 [details] [diff] [review]
updated path

move has-review from previous patch to this one as per Kai's implicit approval.
Attachment #64618 - Flags: review+

Updated

16 years ago
Keywords: patch, review

Comment 13

16 years ago
who should super-review this?

Comment 14

16 years ago
nsbeta1
Keywords: nsbeta1

Comment 15

16 years ago
nsbeta1+
Keywords: nsbeta1 → nsbeta1+

Updated

16 years ago
Blocks: 140346

Updated

16 years ago
Attachment #64618 - Flags: superreview+

Comment 16

16 years ago
Comment on attachment 64618 [details] [diff] [review]
updated path

sr=alecf
(Assignee)

Comment 17

16 years ago
Stephane, as you produced the patch, do you want to check it in?
Let me know if I should do it.
(Assignee)

Comment 18

16 years ago
taking
Assignee: javi → kaie
Keywords: review
Whiteboard: [adt2 rtm]
(Assignee)

Comment 19

16 years ago
Checked in to trunk.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Keywords: adt1.0.0
Resolution: --- → FIXED

Comment 20

16 years ago
Verified on the 5/29 Win2000 trunk.
(Assignee)

Updated

16 years ago
Keywords: adt1.0.0 → adt1.0.1, mozilla1.0.1

Comment 21

16 years ago
adt1.0.1- per ADT triage, for the follwoing reasons.

1.  The pref that has this problem isn't the default selection.
2.  My guess is this panel isn't being accessed too often by people not working
on the feature.
3.  It has an easy workaround - you can tab pretty quickly back to the tree of
panels.
Keywords: adt1.0.1 → adt1.0.1-

Comment 22

16 years ago
Verified.
Status: RESOLVED → VERIFIED
Whiteboard: [adt2 rtm] → [adt2 rtm] fixed on trunk
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.