1101978 - Deal with removal of the plugin finder service.

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[[e-mail]]

Bug 836415 removed the PFS, so we shouldn't try to launch it.

Comment 1

[[e-mail]]

Attachment: Branch-safe patch

Comment 2

[[e-mail]]

Attachment: Remove strings on trunk

Comment 3

[Philip Chee]

Comment on attachment 8525650 [details] [diff] [review]
Branch-safe patch

>              case nsIObjectLoadingContent.PLUGIN_UNSUPPORTED:
> -              // For broken non-object plugin tags, register a click handler so
> -              // that the user can click the plugin replacement to get the new
> -              // plugin. Object tags can, and often do, deal with that
> -              // themselves, so don't stomp on the page developer's toes.
> -              if (!(plugin instanceof HTMLObjectElement)) {
> -                // We don't yet check to see if there's actually an installer available.
> -                var installStatus = this.getPluginUI(plugin, "installStatus");
> -                installStatus.setAttribute("status", "ready");
> -                var iconStatus = this.getPluginUI(plugin, "icon");
> -                iconStatus.setAttribute("status", "ready");
> -                var installLink = this.getPluginUI(plugin, "installPluginLink");
> -                this.addLinkClickCallback(installLink, installMissingPlugins);
> -              }
> -
>                notification = "missing-plugins";
>                message = this._stringBundle.GetStringFromName("missingpluginsMessage.title");

Why do we even show a notification at all?

>       <handler event="NewPluginInstalled" phase="capturing">

This should be removed as nothing dispatches this event after Bug 836415.

https://hg.mozilla.org/mozilla-central/rev/d1ae4274cf8b#l6.30
>     6.30 -  ok(PopupNotifications.getNotification("plugins-not-found", gTestBrowser), "Test 1a, Should have displayed the missing plugin notification");
>     6.31 -  ok(gTestBrowser.missingPlugins, "Test 1a, Should be a missing plugin list");
>     6.32 -  ok(gTestBrowser.missingPlugins.has("application/x-unknown"), "Test 1a, Should know about application/x-unknown");
>     6.33 -  ok(!gTestBrowser.missingPlugins.has("application/x-test"), "Test 1a, Should not know about application/x-test");

Since we have plugin notification tests ported over from Firefox, we should fix out tests too.

Comment 4

[[e-mail]]

Attachment: Branch-safe patch

Comment 5

[[e-mail]]

Aargh, stupid Bugzilla, submitted when I didn't want to and even ignored what I'd already typed.

Comment 6

[[e-mail]]

Attachment: Branch-safe patch

a) Why not? But to make it more interesting I added a Preferences button.
   Since this is still branch-safe I reused an existing string.
b) Good catch, and I removed all of the missingPlugins logic too.
c) Tests don't need fixing because the notification is still there.

Comment 7

[[e-mail]]

Comment on attachment 8527252 [details] [diff] [review]
Branch-safe patch

Pushed comm-central changeset 87542e9d358f.

Comment 8

[[e-mail]]

Comment on attachment 8525652 [details] [diff] [review]
Remove strings on trunk

Pushed comm-central changeset 2a6c7fda0caf.

Comment 9

[[e-mail]]

Comment on attachment 8527252 [details] [diff] [review]
Branch-safe patch

[Approval Request Comment]
Regression caused by (bug #): 836415
User impact if declined: Broken Install Plugins button
String changes made by this patch: None

Comment 10

[[e-mail]]

http://hg.mozilla.org/releases/comm-aurora/rev/8d798926def3
http://hg.mozilla.org/releases/comm-beta/rev/919ddae9cf98

Comment 11

[[e-mail]]

Attachment: Create a separate string rather then reusing the existing string

Comment 12

[Philip Chee]

Comment on attachment 8530674 [details] [diff] [review]
Create a separate string rather then reusing the existing string

This is for trunk right?

Comment 13

[[e-mail]]

Pushed comm-central changeset d26bc10d5d37.

(In reply to Philip Chee from comment #12)
> (From update of attachment 8530674 [details] [diff] [review])
> 
> This is for trunk right?

Right.