1101981 - Moderator should use "object-fit: cover" for profile photos displayed next to questions

Status: RESOLVED WONTFIX

(Participation Infrastructure Graveyard :: Moderator, defect)

Description

[Daniel Holbert [:dholbert]]

In the profile images that Moderator displays next to users' questions, their faces may be squashed, if their profile photo is tall & skinny. (since moderator places it in a square <img> element)

"object-fit: cover" will fix this by preserving the image's aspect ratio when scaling it down.

(Note: "cover" ensures that we'll fill the <img> content-box entirely, probably with a little overflow. The overflow will be centered, due to the default value of "object-fit"; I assume a bit of overflow is fine, given that we're already forcing overflow by placing a circular clip-region over the image.)

Comment 1

[Daniel Holbert [:dholbert]]

"object-fit" support was only just recently added on Nightly, here:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1099450

So it's not available in non-Nightly Firefox versions yet, but it will be when that change rides the trains (and the profile-images will get better-looking, if we've fixed Moderator to take advantage of it).

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of how tall profile images currently render on moderator (squashed vertically)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screenshot with "object-fix: cover" added to the <img> (locally, in devtools)

Comment 4

[Daniel Holbert [:dholbert]]

Hmm, as noted in bug 1035475, it sounds like this bugzilla component isn't monitored, and I should perhaps file this at github ( https://github.com/mozilla/mozmoderator/issues/ ) instead.

Comment 5

[Daniel Holbert [:dholbert]]

Looks like this general issue is tracked at https://github.com/mozilla/mozmoderator/issues/70 -- I added a note there.

Comment 6

[David Lawrence [:dkl]]

Closing due to bug 1325337.

Comment 7

[Daniel Holbert [:dholbert]]

OK. I've now filed https://github.com/mozilla/mozmoderator/issues/164 and posted a suggested fix in https://github.com/mozilla/mozmoderator/issues/165