Closed Bug 1102050 Opened 5 years ago Closed 5 years ago

when the panel is opened, the minimized button needs to be pressed twice

Categories

(Firefox :: Search, defect)

defect
Not set
Points:
5

Tracking

()

VERIFIED FIXED
Firefox 37
Iteration:
37.3 - 12 Jan
Tracking Status
firefox33 --- unaffected
firefox34 + wontfix
firefox35 + wontfix
firefox36 + verified
firefox37 + verified
firefox-esr31 --- unaffected

People

(Reporter: kjozwiak, Assigned: mossop)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached image minimizingTwice.gif
While the search menu is visible, selecting the "minimize" button will dismiss the search menu but will not minimize the browser. Selecting the minimize button the second time around will correctly minimize the browser (sometimes you'll have to press minimize three times). The user shouldn't have to press the minimize button more than once.

Attached a .gif that demonstrates the issue.
QA Contact: kamiljoz
This is the consumeoutsideclicks issue I mentioned via email, I think it's already on Florian's list.
Assignee: nobody → florian
OS: Mac OS X → All
Hardware: x86 → All
After reviewing with Gavin, this is a wontfix for Firefox 34. I have tracked for 35+.
Flags: firefox-backlog?
Flags: firefox-backlog? → firefox-backlog+
Blocks: 1107544
Can you give this a points value please Felipe?
Assignee: florian → felipc
Flags: qe-verify?
I'll set this to 5 because, after talking to Florian, this bug will require some investigation to figure out what's going on and what needs to be fixed. It looks like a consumeoutsideclicks issue, but in fact this panel has consumeoutsideclicks=false. And it works properly for clicks in the toolbar but not on content. So there's something funky going on
Points: --- → 5
Flags: qe-verify? → qe-verify+
(In reply to :Felipe Gomes from comment #4)
> I'll set this to 5 because, after talking to Florian, this bug will require
> some investigation to figure out what's going on and what needs to be fixed.
> It looks like a consumeoutsideclicks issue, but in fact this panel has
> consumeoutsideclicks=false. And it works properly for clicks in the toolbar
> but not on content. So there's something funky going on

I'm not sure it is working properly for clicks in the toolbar. Try typing some stuff into the search box then while the panel is open click somewhere in the text you typed. The panel closes but the caret doesn't move to where you clicked.
I've inadvertently ended up with the fix for this in the patch for bug 1103455
Assignee: felipc → dtownsend
Depends on: 1103455
Status: NEW → ASSIGNED
Iteration: --- → 37.2
No longer blocks: 1107544
No longer depends on: 1103455
Iteration: 37.2 → 37.3
(In reply to Dave Townsend [:mossop] from comment #6)
> I've inadvertently ended up with the fix for this in the patch for bug
> 1103455

Is this FIXED now then?
Flags: needinfo?(dtownsend)
(In reply to :Gavin Sharp [email: gavin@gavinsharp.com] from comment #7)
> (In reply to Dave Townsend [:mossop] from comment #6)
> > I've inadvertently ended up with the fix for this in the patch for bug
> > 1103455
> 
> Is this FIXED now then?

No, we ended up not including that piece as it added some other issues and we wanted to make the beta cut-off.
Flags: needinfo?(dtownsend)
Talked with Mossop in IRC - we're too late for 35 so wontfixing and he's planning to work on this for 36.
Attached file MozReview Request: bz://1102050/Mossop (obsolete) —
Attachment #8543067 - Flags: review?(felipc)
/r/1863 - Bug 1102050: Set consumeoutsideclicks="false" whenever the popup is opened.

Pull down this commit:

hg pull review -r 1e413c645cc0445089f0214a6d3b68365b47ca80
Attachment #8543067 - Flags: review?(felipc) → review+
https://reviewboard.mozilla.org/r/1861/#review1245

::: browser/components/search/test/browser_searchbar_openpopup.js
(Diff revision 1)
> +  textbox.value = "foo";

it's unclear to me how the tests in this file manage to not trigger search suggestions, as it doesn't set the suggest.enabled pref to false. An existing problem (if it is one), but worth double checking
(In reply to :Felipe Gomes from comment #12)
> https://reviewboard.mozilla.org/r/1861/#review1245
> 
> ::: browser/components/search/test/browser_searchbar_openpopup.js
> (Diff revision 1)
> > +  textbox.value = "foo";
> 
> it's unclear to me how the tests in this file manage to not trigger search
> suggestions, as it doesn't set the suggest.enabled pref to false. An
> existing problem (if it is one), but worth double checking

They do trigger suggestions, but the first thing the test does is install a special search engine that doesn't hit the network: http://mxr.mozilla.org/mozilla-central/source/browser/components/search/test/browser_searchbar_openpopup.js#37
https://hg.mozilla.org/mozilla-central/rev/c738f8368814
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
I was able to reproduce this issue on Firefox 34 Beta 11 (20141120192249) using Windows 7 x64.

Verified fixed on Firefox 37.0a1 (2015-01-08) using Windows 7 x64, Ubuntu 14.04 x86 and Mac OSX 10.9.5
Status: RESOLVED → VERIFIED
Dave, can we have an uplift request for aurora (37) & beta (36)?
Flags: needinfo?(dtownsend)
Comment on attachment 8543067 [details]
MozReview Request: bz://1102050/Mossop

Approval Request Comment
[Feature/regressing bug #]: New search bar work
[User impact if declined]: Clicking outside the search bar dismisses the popup but you have to click again
[Describe test coverage new/current, TBPL]: Automated tests on m-c since landing
[Risks and why]: Low risk, the code change here is minimal.
[String/UUID change made/needed]: None
Flags: needinfo?(dtownsend)
Attachment #8543067 - Flags: approval-mozilla-beta?
Attachment #8543067 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed using:

FF 36.0b2
Build Id:20150120155007
OS: Win 7 x64, Mac Os X 10.9.5, Ubuntu 12.04 x32
Attachment #8543067 - Attachment is obsolete: true
Attachment #8618659 - Flags: review+
You need to log in before you can comment on or make changes to this bug.