1102107 - require("toolkit/loader") throws

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attempt to require("toolkit/loader") currently throws exception. Expected behavior would be to return same loader as you get from Cu.import

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Fix V1

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8525833 [details] [review]
Fix V1

One nit, looks good though

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1a0010e5cd93177a5d471f333bdd6fd3dc6a6f09
Merge pull request #1723 from Gozala/bug/require-toolkit-loader

Bug 1102107 - fix require("toolkit/loader") r=@jsantell

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

This either needs to be reverted or fixed in order for us to do an uplift, fixing it is probably easier than reverting, since reverting breaks other resolved bugs.

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

See Bug 1122978 comment 9 and Bug 1120427 comment 8 for more information about the issue here.

Comment 6

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Fix for the loader that should work in b2g setup

Comment 7

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7513e5c0b438

Comment 8

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Irakli Gozalishvili [:irakli] [:gozala] [@gozala] from comment #7)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=7513e5c0b438

Looks like this line should be removed.

https://github.com/mozilla/gecko-dev/blob/452a379c973581106a2c884224e984277fe2e663/addon-sdk/moz.build#L24

Comment 9

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8554026 [details] [review]
Fix for the loader that should work in b2g setup

It looks like tabs are being used instead of spaces ina few places and that is making these files hard to read.

Also we should use the sdk/net/url readURI function instead of making a function to do the same work.

I'd like to see some successful results on try before landing.

Comment 10

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 8554026 [details] [review]
Fix for the loader that should work in b2g setup

I have address review comments, so re-requesting review and pushing again to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=77bada96b050

Comment 11

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

I made a mistake so I had to cancel try build and re-trigger new one:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=54980fb0a958

Comment 12

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/acb0c8009444205d212471bce95f89d3578a1904
Fix regression caused by Bug 1102107 in b2g context.

https://github.com/mozilla/addon-sdk/commit/2b5fe97a66bf976b8a4ad608120c658713af4dad
Merge pull request #1832 from Gozala/loader

Bug 1102107 - Fix issues introduced by loader changes in b2g settings r=@erikvold