Closed Bug 1102111 Opened 10 years ago Closed 10 years ago

[MCTS] error on test "webapi_tests.bluetooth.test_bluetooth_discovery.TestBluetoothDiscovery.test_discovering"

Categories

(Firefox OS Graveyard :: Certification Suite, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pkj1020, Assigned: oouyang)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.65 Safari/537.36

Steps to reproduce:

I have conducted MCTS using the FxOS device (NOT Flame).


Actual results:

BluetoothAdapter.stopDiscovery returned error.

===================================================
Traceback (most recent call last):
File "/root/Desktop/fxos-MCTS-2.0/certsuite_venv/local/lib/python2.7/site-packages/fxos_certsuite-2.0.1-py2.7.egg/webapi_tests/bluetooth/test_bluetooth_discovery.py", line 91, in test_discovering
self.stop_bt_discovery()
File "/root/Desktop/fxos-MCTS-2.0/certsuite_venv/local/lib/python2.7/site-packages/fxos_certsuite-2.0.1-py2.7.egg/webapi_tests/bluetooth/bluetooth_test.py", line 332, in stop_bt_discovery
self.fail("BluetoothAdapter.stopDiscovery returned error")
AssertionError: BluetoothAdapter.stopDiscovery returned error
===================================================
The stopDiscovery has to be called when Discovery is working. The stopDiscovery is called after 30 seconds in this test. But certain devices are ended the discovery about 15sec~20sec. The test case might be modified. 



Expected results:

Always "PASS"
I think this test case should check if the discovery is running or not, before calling stopDiscovery.
For this purpose, we can use BluetoothAdapter.discovering which indicates if the device is in the process of discovering (true) or not (false).
 - https://developer.mozilla.org/en-US/docs/Web/API/BluetoothAdapter.discovering
Hi Jonathan, would you please kindly check this and provide your comments on this ? 

Thank you very much!
Flags: needinfo?(jgriffin)
Hi Jongsoo, thanks for your kindly support.

If possible, could you please kindly provide any related logs for our further investigation ?

Thank you very much!
Flags: needinfo?(zzongsoo)
Flags: needinfo?(pkj1020)
(In reply to Youngwoo Jo from comment #1)
> I think this test case should check if the discovery is running or not,
> before calling stopDiscovery.
> For this purpose, we can use BluetoothAdapter.discovering which indicates if
> the device is in the process of discovering (true) or not (false).
>  -
> https://developer.mozilla.org/en-US/docs/Web/API/BluetoothAdapter.discovering

Agreed, this is the correct solution.
Flags: needinfo?(jgriffin)
Status: UNCONFIRMED → NEW
Ever confirmed: true
comment 4, the solution might be confirmed.
Flags: needinfo?(zzongsoo)
Flags: needinfo?(pkj1020)
Blocks: 1089554
Assignee: nobody → oouyang
Please help me to check it.
Attachment #8541587 - Flags: review?(jgriffin)
Attachment #8541587 - Flags: review?(atsai)
Comment on attachment 8541587 [details] [review]
check discovering mode before stop discovering

This looks good.   Please land in the main fxos-certsuite repo as well.
Attachment #8541587 - Flags: review?(jgriffin) → review+
Comment on attachment 8541587 [details] [review]
check discovering mode before stop discovering

r+.
Attachment #8541587 - Flags: review?(atsai) → review+
Blocks: 1116401
merged
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: