Closed Bug 1102132 Opened 5 years ago Closed 5 years ago

[Messages][RTL] Move the "sliding" transition back to be the same than in LTR conditions

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
2.2 S1 (5dec)

People

(Reporter: julienw, Assigned: azasypkin)

References

Details

(Keywords: rtl, Whiteboard: [p=1])

Attachments

(2 files)

It's been decided that in v2.2 the sliding transition would be the same whether we're in LTR or RTL.
See Also: → 1102138
Hey Steve,

Could you please review another tiny RTL patch? :)

Thanks!
Assignee: nobody → azasypkin
Status: NEW → ASSIGNED
Attachment #8529711 - Flags: review?(schung)
Whiteboard: [p=1]
Keywords: rtl
Target Milestone: --- → 2.2 S1 (5dec)
Comment on attachment 8529711 [details] [review]
GitHub pull request URL

LGTM, thanks!
Attachment #8529711 - Flags: review?(schung) → review+
(In reply to Steve Chung [:steveck] from comment #2)
> Comment on attachment 8529711 [details] [review]
> GitHub pull request URL
> 
> LGTM, thanks!

Thanks for review!

Master: https://github.com/mozilla-b2g/gaia/commit/6596ec05b9d00166929fe4bcda1c5c44bad4174c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
This issue is verified pass on latest flame 2.2&3.0 and Nexus 5 2.2&3.0 build.
The STR is as follow:
1.Set your phone language to Arabic.
2.Launch Message.
3.Switching between different pages.
** "Sliding" transition is same as that in LTR conditions.

See attachment:Verify1_Flame 2.2&3.0_N5 2.2&3.0_Pass.mp4.
Reproducing rate:0/20

Device:Flame 2.2 build (Pass)
Build ID               20150525162504
Gaia Revision          144673a413586f98b5e2c27b781c1a539611f754
Gaia Date              2015-05-25 02:01:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/115112d51e08
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150525.202102
Firmware Date          Mon May 25 20:21:12 EDT 2015
Bootloader             L1TC000118D0

Device:Flame 3.0 build (Pass)
Build ID               20150525160205
Gaia Revision          5bcc08a732163087999251b523e3643db397412c
Gaia Date              2015-05-24 14:44:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b6623a27fa64
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150525.192755
Firmware Date          Mon May 25 19:28:07 EDT 2015
Bootloader             L1TC000118D0

Device:Nexus 5 2.2 build (Pass)
Build ID               20150525002504
Gaia Revision          144673a413586f98b5e2c27b781c1a539611f754
Gaia Date              2015-05-25 02:01:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c4db2af40b1b
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150525.041303
Firmware Date          Mon May 25 04:13:19 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 3.0 build (Pass)
Build ID               20150525160205
Gaia Revision          5bcc08a732163087999251b523e3643db397412c
Gaia Date              2015-05-24 14:44:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/b6623a27fa64
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150525.192207
Firmware Date          Mon May 25 19:22:24 EDT 2015
Bootloader             HHZ12f
Status: RESOLVED → VERIFIED
QA Whiteboard: [MGSEI-Triage+]
You need to log in before you can comment on or make changes to this bug.