Closed
Bug 1102137
Opened 10 years ago
Closed 9 years ago
Add Bing, remove Amazon and eBay for Turkish Firefox
Categories
(Mozilla Localizations :: tr / Turkish, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: selim, Assigned: selim)
Details
Attachments
(1 file, 1 obsolete file)
|
267 bytes,
patch
|
flod
:
review+
|
Details | Diff | Splinter Review |
After a discussion within the Turkish l10n team, we have decided to update our search engine list.
We are adding Bing as the 3rd generic search engine option (after Google and Yandex), as we think that it has matured enough to be included in Firefox.
We are also going to remove Amazon and eBay since we think that they are mostly useless for the average Turkish user. In the meantime, we are actively looking for high-quality Turkey-based e-commerce companies that might be interested in revenue generating deals with Mozilla.
Attachment #8525882 -
Flags: review?(themilossh)
Comment 1•10 years ago
|
||
Comment on attachment 8525882 [details] [diff] [review]
list.txt patch for tr
This simply adds Bing to the list, not as a third search-engine. The order in list.txt is irrelevant, so I always suggest to use alphabetical order.
To add Bing as 3rd engine you need to add a line in region.properties
http://hg.mozilla.org/releases/l10n/mozilla-aurora/tr/file/f01bdfdae4b7/browser/chrome/browser-region/region.properties#l15
browser.search.order.3=Bing
Cleaning up review request for now (I'd be the right person to point it to), also because we have other pending changes these days.
Also: Mike, should we keep Amazon and eBay in and simply add Bing?
Flags: needinfo?(mconnor)
Attachment #8525882 -
Flags: review?(themilossh)
| Assignee | ||
Comment 2•10 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #1)
> To add Bing as 3rd engine you need to add a line in region.properties
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/tr/file/f01bdfdae4b7/
> browser/chrome/browser-region/region.properties#l15
I'll fix that as well. Should I do anything about DuckDuckGo or is it added automatically?
AFAIK, eBay doesn't pay for the Turkish locale (see bug 949460). I'm not sure about Amazon though.
Flags: needinfo?(francesco.lodolo)
Comment 3•10 years ago
|
||
(In reply to Selim Şumlu from comment #2)
> I'll fix that as well. Should I do anything about DuckDuckGo or is it added
> automatically?
That's one of the pending changes. Right now it's added for all locales at build time, we need to figure out when we should start to manually add it to locales.
Flags: needinfo?(francesco.lodolo)
| Assignee | ||
Comment 4•10 years ago
|
||
Mike, can we have an update regarding this bug?
Comment 5•10 years ago
|
||
I'll check in on any contractual requirements today.
| Assignee | ||
Comment 6•10 years ago
|
||
Pinging Mike...
Comment 7•10 years ago
|
||
There is nothing contractual that prevents us from removing these partners, but I ask that you consider that our agreements are based on our partners geo-location. For example, if a user of the TR version is physically in the US, UK, DE or some other "covered" country, then we would no longer be generating revenue. I have not had the opportunity to work with metrics to determine what that usage might look like. Is keeping these in the search default list a major issue for this locale?
Updated•10 years ago
|
Flags: needinfo?(mconnor)
| Assignee | ||
Comment 8•10 years ago
|
||
Even though I wouldn't consider this as a major issue, we aim to keep the best and most relevant search providers only. We believe eBay and Amazon are irrelevant for most of our locale's users.
I suggest looking up if we're actually generating meaningful revenue from these providers. If we are, then we should keep them. Otherwise we should execute our decision to remove them.
Flags: needinfo?(jnagel)
Comment 9•10 years ago
|
||
I have requested search volume data from Metrics so we can evaluate this, I will update the bug when I have received it.
Flags: needinfo?(jnagel)
Comment 10•10 years ago
|
||
Okay, I've evaluated the data from FHR for both Geo and Locale. One thing I found interesting was that Amazon had more searches (for a specific time reported) than Wikipedia or Twitter, although none of these partners had substantial volume. If you still want to remove them from the search plugin, then I am comfortable with that.
| Assignee | ||
Comment 11•9 years ago
|
||
Thanks, Joanne.
flod, can you review this?
Attachment #8525882 -
Attachment is obsolete: true
Attachment #8687893 -
Flags: review?(francesco.lodolo)
Comment 12•9 years ago
|
||
Comment on attachment 8687893 [details] [diff] [review]
lists.txt patch for tr
Review of attachment 8687893 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM based on the discussion, thanks.
Attachment #8687893 -
Flags: review?(francesco.lodolo) → review+
| Assignee | ||
Comment 13•9 years ago
|
||
Confirmed changes on Developer Edition.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 14•9 years ago
|
||
Putting link for reference
http://hg.mozilla.org/releases/l10n/mozilla-aurora/tr/rev/794b7eec8f82
http://hg.mozilla.org/l10n-central/tr/rev/794b7eec8f82
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•