Closed Bug 1102144 Opened 10 years ago Closed 10 years ago

MediaSourceReader.cpp get compile error when MOZ_FMP4 is disabled

Categories

(Core :: Audio/Video, defect)

ARM
Gonk (Firefox OS)
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: seinlin, Assigned: seinlin)

Details

Attachments

(2 files)

There is an option to enable/disable MOZ_FMP4, but MediaSourceReader.cpp get compile error when MOZ_FMP4 is disabled.
Blake, could you have a look to this patch? If it is reasonable, let's submit a formal patch to land it. Thanks!
Attachment #8525899 - Flags: review?(bwu)
Attachment #8525899 - Flags: review?(bwu) → feedback?(bwu)
Comment on attachment 8525899 [details] [diff] [review]
MediaSourceReader.patch

Review of attachment 8525899 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!
Just one concern for the changes in configure.in. Please have a check.

::: configure.in
@@ +298,5 @@
>          AC_DEFINE(MOZ_AUDIO_OFFLOAD)
> +        MOZ_FMP4=
> +        MOZ_WEBRTC=
> +        MOZ_NUWA_PROCESS=
> +        MOZ_B2G_LOADER=

MOZ_WEBRTC=
MOZ_NUWA_PROCESS=
MOZ_B2G_LOADER=
These should not be added in this patch since it has nothing to do with the FMP4.
Attachment #8525899 - Flags: feedback?(bwu) → feedback+
Thanks! I will export a formal patch for reviewing.
Blake, Could you review this patch? Thanks!
Attachment #8526528 - Flags: review?(bwu)
Comment on attachment 8526528 [details] [diff] [review]
bug-1102144.patch

Review of attachment 8526528 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!.
Need ajones review.
Attachment #8526528 - Flags: review?(bwu)
Attachment #8526528 - Flags: review?(ajones)
Attachment #8526528 - Flags: review+
Attachment #8526528 - Flags: review?(ajones) → review+
https://hg.mozilla.org/mozilla-central/rev/b0f33e4e1232
Assignee: nobody → kli
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.