Closed
Bug 1102144
Opened 10 years ago
Closed 10 years ago
MediaSourceReader.cpp get compile error when MOZ_FMP4 is disabled
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: seinlin, Assigned: seinlin)
Details
Attachments
(2 files)
2.01 KB,
patch
|
bwu
:
feedback+
|
Details | Diff | Splinter Review |
1.75 KB,
patch
|
bwu
:
review+
ajones
:
review+
|
Details | Diff | Splinter Review |
There is an option to enable/disable MOZ_FMP4, but MediaSourceReader.cpp get compile error when MOZ_FMP4 is disabled.
Assignee | ||
Comment 1•10 years ago
|
||
Blake, could you have a look to this patch? If it is reasonable, let's submit a formal patch to land it. Thanks!
Attachment #8525899 -
Flags: review?(bwu)
Assignee | ||
Updated•10 years ago
|
Attachment #8525899 -
Flags: review?(bwu) → feedback?(bwu)
Comment 2•10 years ago
|
||
Comment on attachment 8525899 [details] [diff] [review] MediaSourceReader.patch Review of attachment 8525899 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me! Just one concern for the changes in configure.in. Please have a check. ::: configure.in @@ +298,5 @@ > AC_DEFINE(MOZ_AUDIO_OFFLOAD) > + MOZ_FMP4= > + MOZ_WEBRTC= > + MOZ_NUWA_PROCESS= > + MOZ_B2G_LOADER= MOZ_WEBRTC= MOZ_NUWA_PROCESS= MOZ_B2G_LOADER= These should not be added in this patch since it has nothing to do with the FMP4.
Attachment #8525899 -
Flags: feedback?(bwu) → feedback+
Assignee | ||
Comment 3•10 years ago
|
||
Thanks! I will export a formal patch for reviewing.
Assignee | ||
Comment 4•10 years ago
|
||
Blake, Could you review this patch? Thanks!
Attachment #8526528 -
Flags: review?(bwu)
Comment 5•10 years ago
|
||
Comment on attachment 8526528 [details] [diff] [review] bug-1102144.patch Review of attachment 8526528 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me!. Need ajones review.
Attachment #8526528 -
Flags: review?(bwu)
Attachment #8526528 -
Flags: review?(ajones)
Attachment #8526528 -
Flags: review+
Updated•10 years ago
|
Attachment #8526528 -
Flags: review?(ajones) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Try result: https://tbpl.mozilla.org/?tree=Try&rev=67197c6015a2
Assignee | ||
Comment 7•10 years ago
|
||
http://hg.mozilla.org/integration/b2g-inbound/rev/b0f33e4e1232
https://hg.mozilla.org/mozilla-central/rev/b0f33e4e1232
Assignee: nobody → kli
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•