[Stingray][home] create button-group and apply to settings button in home app

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: johnhu, Assigned: johnhu)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 attachment, 1 obsolete attachment)

Please implement button group and apply to settings button in home header buttons (p.3)
Before implement the button group, I will create a simple-text-button which is at row 1, col 3 at the video of building block.
Created attachment 8527492 [details] [review]
add menu group

This patch contains the patch of bug 1102142 because this one depends on it. Please review the second one. Thanks.
Attachment #8527492 - Flags: review?(tzhuang)
Created attachment 8528282 [details] [review]
rebased patch

The patch is the same as previous one but rebased. Please review this one.
Attachment #8527492 - Attachment is obsolete: true
Attachment #8527492 - Flags: review?(tzhuang)
Attachment #8528282 - Flags: review?(tzhuang)
Comment on attachment 8528282 [details] [review]
rebased patch

Looks good to me. Thanks

Though I think using event emitter and dispatching custom event in menu group at the same time is a bit redundant, I could accept it to land as is.
Attachment #8528282 - Flags: review?(tzhuang) → review+
I did this for supporting both two kind of event system. In our smart-home app, we all use JS event which provides us better performance. If the user wants to use custom event, it should also be supported. That's the reason I put two of them. Once we move these components as building block, we should make a final decision to keep which one.
merged to master:
https://github.com/mozilla-b2g/gaia/commit/268709bdc6c48961b493e88abfb46181b47e1252

gaia-try is all green after retries.
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=6f350792b3c8
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.