[Bluetooth] Port Bug 1100883 to bluetooth2

RESOLVED FIXED

Status

Firefox OS
Bluetooth
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

Comment hidden (empty)
Created attachment 8528366 [details] [diff] [review]
[01] Bug 1102161: Move helpers of |BluetoothServiceBluedroid| into its namespace
Attachment #8528366 - Flags: review?(btian)
Created attachment 8528367 [details] [diff] [review]
[02] Bug 1102161: Move |ToggleBtAck| into |BluetoothService|
Attachment #8528367 - Flags: review?(btian)
Created attachment 8528368 [details] [diff] [review]
[03] Bug 1102161: Replace most instances of |ToggleBtAck| with calls to |AcknowledgeToggleBt|
Attachment #8528368 - Flags: review?(btian)
Created attachment 8528369 [details] [diff] [review]
[04] Bug 1102161: Cleanup |BluetoothServiceBluedroid::AdapterStateChangedNotification|
Attachment #8528369 - Flags: review?(btian)

Comment 5

4 years ago
Comment on attachment 8528366 [details] [diff] [review]
[01] Bug 1102161: Move helpers of |BluetoothServiceBluedroid| into its namespace

Review of attachment 8528366 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed.

::: dom/bluetooth2/bluedroid/BluetoothServiceBluedroid.cpp
@@ +133,1 @@
>  : public BluetoothProfileResultHandler

nit: indent 2 spaces for consistency.

@@ +274,1 @@
>  : public BluetoothProfileResultHandler

nit: indent 2 spaces for consistency.
Attachment #8528366 - Flags: review?(btian) → review+

Comment 6

4 years ago
Comment on attachment 8528367 [details] [diff] [review]
[02] Bug 1102161: Move |ToggleBtAck| into |BluetoothService|

Review of attachment 8528367 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8528367 - Flags: review?(btian) → review+

Comment 7

4 years ago
Comment on attachment 8528368 [details] [diff] [review]
[03] Bug 1102161: Replace most instances of |ToggleBtAck| with calls to |AcknowledgeToggleBt|

Review of attachment 8528368 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8528368 - Flags: review?(btian) → review+

Comment 8

4 years ago
Comment on attachment 8528369 [details] [diff] [review]
[04] Bug 1102161: Cleanup |BluetoothServiceBluedroid::AdapterStateChangedNotification|

Review of attachment 8528369 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.

::: dom/bluetooth2/bluedroid/BluetoothServiceBluedroid.cpp
@@ +1074,5 @@
>  //
>  // Bluetooth notifications
>  //
>  
> +/* |ProfileDeinitResultHandler| collect the results of all profile

collects
Attachment #8528369 - Flags: review?(btian) → review+
Created attachment 8530219 [details] [diff] [review]
[01] Bug 1102161: Move helpers of |BluetoothServiceBluedroid| into its namespace (v2)

Changes since v1:

  - fixed indention
Attachment #8528366 - Attachment is obsolete: true
Attachment #8530219 - Flags: review+
Created attachment 8530221 [details] [diff] [review]
[04] Bug 1102161: Cleanup |BluetoothServiceBluedroid::AdapterStateChangedNotification| (v2)

Changes since v1:

  - rebased on [01]
  - fixed typo in comment
Attachment #8528369 - Attachment is obsolete: true
Attachment #8530221 - Flags: review+
You need to log in before you can comment on or make changes to this bug.