Closed
Bug 1102308
Opened 10 years ago
Closed 10 years ago
Refactor pref-changed emitting in toolbox-options.js
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(1 file)
4.49 KB,
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
There are 4 places that are sharing the code needed to emit a pref-changed event on gDevTools. See bug 1097156 comment 10.
Assignee | ||
Comment 1•10 years ago
|
||
Ryan, what do you think? Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=a46378989306
Comment on attachment 8526328 [details] [diff] [review] options-refactor.patch Review of attachment 8526328 [details] [diff] [review]: ----------------------------------------------------------------- Seems good to me!
Attachment #8526328 -
Flags: review?(jryans) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/709fd162929e
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/709fd162929e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•