Closed Bug 1102308 Opened 10 years ago Closed 10 years ago

Refactor pref-changed emitting in toolbox-options.js

Categories

(DevTools :: Framework, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 36

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file)

There are 4 places that are sharing the code needed to emit a pref-changed event on gDevTools.  See bug 1097156 comment 10.
Ryan, what do you think?  Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=a46378989306
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8526328 - Flags: review?(jryans)
Comment on attachment 8526328 [details] [diff] [review]
options-refactor.patch

Review of attachment 8526328 [details] [diff] [review]:
-----------------------------------------------------------------

Seems good to me!
Attachment #8526328 - Flags: review?(jryans) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/709fd162929e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.