1102319 - Keypad solid-colored buttons are bunched up too much

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Doug Sherk (:drs) (inactive)]

The buttons at the bottom of the keypad for placing a call and creating a contact with the currently-entered number are too bunched up. This is likely a `margin-(left|right)` issue.

Comment 1

[Doug Sherk (:drs) (inactive)]

Attachment: Screenshot

Comment 2

[Doug Sherk (:drs) (inactive)]

Attachment: Screenshot 2

Comment 3

[Doug Sherk (:drs) (inactive)]

Write a summary of how I think we can fix this.

Comment 4

[Doug Sherk (:drs) (inactive)]

This looks a bit easier than I thought when I wrote comment 3. I initially believed that this was caused by the issue described in bug 1060293, but after some actual investigation, it doesn't seem to be.

There may be some changes required in addition to the suggestions below.

To fix the issue illustrated in attachment 8526117 [details], we will have to change this [1] `margin-left` to `-moz-margin-start`.

To fix the issue illustrated in attachment 8526118 [details], we will have to change this [2] `margin` to:
```css
margin: 0;
-moz-margin-start: 1rem;
```

Note that for [2], we will have to get a review from peers from the following modules: Contacts, Messages, Building Blocks in addition to Dialer.

[1] https://github.com/mozilla-b2g/gaia/blob/e5d666d6f62480ced56c6d9352f5e12befb5a862/shared/style/dialer/keypad.css#L222
[2] https://github.com/mozilla-b2g/gaia/blob/e5d666d6f62480ced56c6d9352f5e12befb5a862/shared/style/edit_mode.css#L61

Comment 5

[Ahmed Nefzaoui [:Nefzaoui]]

Hey Doug,
Is someone still working on this? :)

Comment 6

[Doug Sherk (:drs) (inactive)]

(In reply to Ahmed Nefzaoui [:Nefzaoui] from comment #5)
> Hey Doug,
> Is someone still working on this? :)

No, feel free to take it.

Comment 7

[GitHub Autolander Bot]

Attachment: [PullReq] anefzaoui:bug-1102319 to mozilla-b2g:master

Comment 8

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8542473 [details] [review]
[PullReq] anefzaoui:bug-1102319 to mozilla-b2g:master

How does that look? :)
Thanks!

Comment 9

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8542473 [details] [review]
[PullReq] anefzaoui:bug-1102319 to mozilla-b2g:master

Looks good, thanks!

Comment 10

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/f6d1ad6a161a2b9da801e163ef86001d1751d65d

Comment 11

[Elie]

This issue verified successfully on Flame 2.2
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8067c111ddff
Build-ID        20150118002501
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
refer to picture 2015-01-19-04-10-51.png

Comment 12

[Elie]

Attachment: 2015-01-19-04-10-51.png

Comment 13

[Alissa（leave from Mozilla）]

Test case has been added in moztrap:

https://moztrap.mozilla.org/manage/case/15418/