1102344 - Call counts are displayed incorrectly in the call log

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[Doug Sherk (:drs) (inactive)]

Attachment: Screenshot

Call counts in the call log are being broken up incorrectly in RTL mode in the call log. See attached screenshot.

Bug 1080828 should provide us with useful guidance here.

Comment 1

[Ahmed Nefzaoui [:Nefzaoui]]

Hey Doug, is there is some work in progress here?

Comment 2

[Doug Sherk (:drs) (inactive)]

(In reply to Ahmed Nefzaoui [:Nefzaoui] from comment #1)
> Hey Doug, is there is some work in progress here?

Nope, feel free to take it.

Comment 3

[Dylan Oliver [:doliver]]

RTL triage: P3 -- this bug is not prioritized for inclusion in the 2.2 release.

Comment 4

[Doug Sherk (:drs) (inactive)]

Dylan, should this be "feature-b2g: 2.2"?

Comment 5

[Dylan Oliver [:doliver]]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #4)
> Dylan, should this be "feature-b2g: 2.2"?

Yes, probably. This was initially judged to be P3 but we've given higher priority to similar bugs liks bug 1125069, so let's bump this up.

Comment 6

[Tamara Hills [:thills]]

Attachment: PR for fix

Comment 7

[Tamara Hills [:thills]]

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=568aace1d2d9

Comment 8

[Tamara Hills [:thills]]

https://github.com/mozilla-b2g/gaia/commit/d83fd4f019c0553a10f06f620cf30cd521873194.

NI to myself to remember to ask for 2.2 approval

Comment 9

[Tamara Hills [:thills]]

Attachment: 2.2 Uplift request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Support for RTL
[User impact] if declined: When in RTL languages, the parenthesis around the call count will be misplaced.
[Testing completed]:yes
[Risk to taking this patch] (and alternatives if risky):low
[String changes made]:no

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/3c58d6487ed65f50bc7f5a3610487623cbcd17a4

Comment 11

[Coler]

This issue has been verified successfully on Flame 3.0.
Reproduce rate:0/5.
Attachment:Verify_Counts.png

Flame 3.0 build:
Gaia-Rev        ae5a1580da948c3b9f93528146b007fc4f6a712b
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/ae5d04409cd9
Build-ID        20150203055658
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150203.093120
FW-Date         Tue Feb  3 09:31:32 EST 2015
Bootloader      L1TC000118D0

Comment 12

[Coler]

Attachment: Verify_Counts.png

Comment 13

[Coler]

This issue can't be repro on latest Flame 2.2
Reproduce rate:0/5

Flame 2.2 build:

Build ID               20150204162500
Gaia Revision          c2047a46e29696238e9b4c9caaba47736421449a
Gaia Date              2015-02-04 20:34:04
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/adfba0a07e9b
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150204.195445
Firmware Date          Wed Feb  4 19:54:56 EST 2015
Bootloader             L1TC000118D0

Comment 14

[Coler]

Attachment: Verify_RTL.png

Comment 15

[Alissa（leave from Mozilla）]

 Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15428/