1102347 - Add links to debugger from call tree in new performance tool

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1102347-link-debugger-to-perf.patch

try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6a55d1e3a299

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 8534708 [details] [diff] [review]
1102347-link-debugger-to-perf.patch

Review of attachment 8534708 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/views/details-call-tree.js
@@ +115,5 @@
> + * file name and line number.
> + * @param string url
> + * @param number line
> + */
> +function viewSourceInDebugger(url, line) {

Can this please become a task already?

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8534708 [details] [diff] [review]
1102347-link-debugger-to-perf.patch

Review of attachment 8534708 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/views/details-call-tree.js
@@ +115,5 @@
> + * file name and line number.
> + * @param string url
> + * @param number line
> + */
> +function viewSourceInDebugger(url, line) {

yes please

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1102347-link-debugger-to-perf.patch

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/9a4e416213cc

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9a4e416213cc