Closed
Bug 1102347
Opened 10 years ago
Closed 10 years ago
Add links to debugger from call tree in new performance tool
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 37
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file, 1 obsolete file)
9.81 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•10 years ago
|
Blocks: perf-tool-v2
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6a55d1e3a299
Attachment #8534708 -
Flags: review?(vporof)
Comment 2•10 years ago
|
||
Comment on attachment 8534708 [details] [diff] [review] 1102347-link-debugger-to-perf.patch Review of attachment 8534708 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/performance/views/details-call-tree.js @@ +115,5 @@ > + * file name and line number. > + * @param string url > + * @param number line > + */ > +function viewSourceInDebugger(url, line) { Can this please become a task already?
Attachment #8534708 -
Flags: review?(vporof) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8534708 [details] [diff] [review] 1102347-link-debugger-to-perf.patch Review of attachment 8534708 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/performance/views/details-call-tree.js @@ +115,5 @@ > + * file name and line number. > + * @param string url > + * @param number line > + */ > +function viewSourceInDebugger(url, line) { yes please
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8534708 -
Attachment is obsolete: true
Attachment #8534737 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/9a4e416213cc
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/9a4e416213cc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•