Closed Bug 1102347 Opened 6 years ago Closed 6 years ago

Add links to debugger from call tree in new performance tool

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

36 Branch
x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 37

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Depends on: 1102350
No longer depends on: 1102350
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Comment on attachment 8534708 [details] [diff] [review]
1102347-link-debugger-to-perf.patch

Review of attachment 8534708 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/views/details-call-tree.js
@@ +115,5 @@
> + * file name and line number.
> + * @param string url
> + * @param number line
> + */
> +function viewSourceInDebugger(url, line) {

Can this please become a task already?
Attachment #8534708 - Flags: review?(vporof) → review+
Comment on attachment 8534708 [details] [diff] [review]
1102347-link-debugger-to-perf.patch

Review of attachment 8534708 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/views/details-call-tree.js
@@ +115,5 @@
> + * file name and line number.
> + * @param string url
> + * @param number line
> + */
> +function viewSourceInDebugger(url, line) {

yes please
Attachment #8534708 - Attachment is obsolete: true
Attachment #8534737 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/9a4e416213cc
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.