Closed Bug 1102404 Opened 10 years ago Closed 10 years ago

Implement Changes To What's New

Categories

(www.mozilla.org :: Project Tracking, defect)

Product:
www.mozilla.org
Component:
Project Tracking
Version:
Production
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bensternthal, Unassigned)

References

Details

User Story

When Someone Lands On Whats new:

- Check default search
- If not yahoo, we randomly select (xx/xx dice roll)
- We force some to be yahoo - display door hanger explaining change
- For the other - display door hanger with button to change to yahoo manually
- Displayed for firefox 34.0 only
- Set tracking string for FHR


Current Needs Captured In Dependent Bugs
- Web Copy & Imagery For /whatsnew page
-- any variants

- Provide Copy For 2 Version Of Door Hanger
-- Your search has been set to yahoo.
-- Set your search to yahoo.
- Icon for doorhanger.
- Tracking strings for FHR.
- Percentage for dice roll.
Bug tracks completion of changes to what's new. Spec is in user story field.
User Story: (updated)
Depends on: 1101790
Depends on: 1102408
Depends on: 1102412
Also need web page copy & imagery for /whatsnew page
User Story: (updated)
Depends on: 1102535
Ok I have a preliminary version up on demo5:

Note: to see the door-hanger & variations people need to white-list demo5 in about:config

1.) Using Firefox 34 Beta, open about:config
2.) create a new preference called "browser.uitour.whitelist.add.testing" (type string)
3.) Set the value to "www-demo5.allizom.org"
4.) Restart the browser an open the URL:

https://www-demo5.allizom.org/en-US/firefox/34.0/whatsnew/?oldversion=33.1.0

Also note that clicking the door-hanger buttons currently does not open the new search menu, as I'm still waiting on Bug 1101670 landing in the next build.
Latest builds to test are here:

http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-beta-macosx64/latest/
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-beta-linux64/latest/
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-beta-win32/latest/

Other things to bear in mind when testing:

- your local date/time needs to fall within a US timezone (else you will just see the default state). We are using the same code as what's used in-product (Bug 1102416) to be consistent.
Some other scenarios where you can see the default state (Sync CTA):

- Default Search engine is not set as either Google or Yahoo.
- Search bar has been removed from the toolbar UI.
I have a question related with the Ui Tour, will be a new Beta release that will contain the UiTour or it will go directly to release? There are still a lot UItour related fixes on beta that need verification and doing it with a tinderbox build might be risky.
Flags: needinfo?(booboobenny+bugzilla)
(In reply to Catalin Varga [QA][:VarCat] from comment #5)
> I have a question related with the Ui Tour, will be a new Beta release that
> will contain the UiTour or it will go directly to release? There are still a
> lot UItour related fixes on beta that need verification and doing it with a
> tinderbox build might be risky.

I think you best ask someone from Firefox engineering on this. Ben is PTO today but I'm not sure he would know the answer?
Flags: needinfo?(booboobenny+bugzilla)
(In reply to Alex Gibson [:agibson] from comment #6)
> (In reply to Catalin Varga [QA][:VarCat] from comment #5)
> > I have a question related with the Ui Tour, will be a new Beta release that
> > will contain the UiTour or it will go directly to release? There are still a
> > lot UItour related fixes on beta that need verification and doing it with a
> > tinderbox build might be risky.
> 
> I think you best ask someone from Firefox engineering on this. Ben is PTO
> today but I'm not sure he would know the answer?

Is Gavin the person to ask?
Flags: needinfo?(gavin.sharp)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to Catalin Varga [QA][:VarCat] from comment #5)
> I have a question related with the Ui Tour, will be a new Beta release that
> will contain the UiTour or it will go directly to release? There are still a
> lot UItour related fixes on beta that need verification and doing it with a
> tinderbox build might be risky.

There are some UITour fixes that didn't make it into the last beta. They all made it into 34.0 RC1, though:

https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/34.0-candidates/build1/
Flags: needinfo?(gavin.sharp)
Using RC1 on demo5: I verified both variants of the doorhanger, default displays when non-google/yahoo search provider is selected, default with Sync displays when signed out of Firefox Accounts.

Signed in to FF account I still see Sync and not Web We Want promo.
Verified that no doorhangers or changes are made if search box is not in the toolbar.
Verified 3 versions of copy: Independence, Ravioli, Flare. Independence shows the promo boxes in a different order from the copy deck: Better results from Yahoo is first, on the left; More choices is on the right.
(In reply to Rebecca Billings [:rbillings] from comment #11)
> Verified 3 versions of copy: Independence, Ravioli, Flare. Independence
> shows the promo boxes in a different order from the copy deck: Better
> results from Yahoo is first, on the left; More choices is on the right.

The Independence layout is as per the PSD design. I'll assume the PSD is correct over the copy doc.
Verified all using RC1 on demo5. Confirmed that users never see Web We Want promo from /whatsnew. Everything else is bueno. Will file new bugs if anything else comes up.
Status: RESOLVED → VERIFIED
The tour doesn't start again after refreshing the demo testing page:
https://www-demo5.allizom.org/en-US/firefox/34.0/whatsnew/?oldversion=33.1.0

This may not be an issue, but please confirm considering that the current tour is launched every time the page is refreshed: https://www.mozilla.org/en-US/firefox/34.0/tour/
Flags: needinfo?(agibson)
(In reply to Petruta Rasa [QA] [:petruta] from comment #14)
> The tour doesn't start again after refreshing the demo testing page:
> https://www-demo5.allizom.org/en-US/firefox/34.0/whatsnew/?oldversion=33.1.0
> 
> This may not be an issue, but please confirm considering that the current
> tour is launched every time the page is refreshed:
> https://www.mozilla.org/en-US/firefox/34.0/tour/

First time you launch the tour, and op-in to using Yahoo - a refresh will then show the default (Sync) promo. This is intended behavior. To see the tour again, set your default back to Google and refresh.

Thanks
Flags: needinfo?(agibson)
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/7cf4fdf480c358a29f6e6623af22d678139a1882
[fix bug 1102404 1102414] Implement firstrun and whatsnew search/Yahoo changes

https://github.com/mozilla/bedrock/commit/c3f839982314346325bbfcf84dd5753a3628dc3f
Merge pull request #2545 from mozilla/yahoo-search-tours

[fix bug 1102404 1102414] Implement firstrun and whatsnew search/Yahoo changes
Status: VERIFIED → RESOLVED
Closed: 10 years ago → 10 years ago
You need to log in before you can comment on or make changes to this bug.