Closed
Bug 1102488
Opened 10 years ago
Closed 9 years ago
Factor out preprocessed Java into a separate library
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
All
Android
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(6 files, 1 obsolete file)
38 bytes,
text/x-review-board-request
|
nalexander
:
review+
|
Details |
38 bytes,
text/x-review-board-request
|
nalexander
:
review+
|
Details |
38 bytes,
text/x-review-board-request
|
nalexander
:
review+
|
Details |
38 bytes,
text/x-review-board-request
|
nalexander
:
review+
|
Details |
38 bytes,
text/x-review-board-request
|
nalexander
:
review+
|
Details |
38 bytes,
text/x-review-board-request
|
nalexander
:
review+
|
Details |
At the moment, generated Java includes both preprocessed Java and aapt-generated Java. IDEs never want our aapt-generated Java: Eclipse, IntelliJ, and other build systems like buck all arrange to get R.java (and Manifest.java) in slightly different ways. Let's make this easier by splitting preprocessed and aapt-generated source. Further, buck makes it difficult to mix Java in the srcdir and objdir. The buck way to do this is mix Java libraries (JAR files) in the srcdir and objdir. This ticket tracks splitting the sources and separating the generated sources into a tiny library independent of the main Fennec sources.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8526375 -
Flags: review?(rnewman)
Assignee | ||
Comment 2•10 years ago
|
||
/r/849 - Bug 1102488 - Pre: Remove unused cruft. r=rnewman /r/851 - Bug 1102488 - Part 1: Factor out constants JAR. r=rnewman /r/853 - Bug 1102488 - Part 2a: Move GeckoLoader. /r/855 - Bug 1102488 - Part 2b: Don't preprocess GeckoLoader. /r/857 - Bug 1102488 - Part 3: Output preprocessed files into generated/preprocessed. r=rnewman /r/859 - Bug 1102488 - Part 4: Make FxAccountConstants independent of Logger. r=rnewman Pull down these commits: hg pull review -r d4bc85c5c958781acef3ecb8e0041877af45b3d0
Comment 3•10 years ago
|
||
https://reviewboard.mozilla.org/r/849/#review401 Ship It!
Comment 4•10 years ago
|
||
https://reviewboard.mozilla.org/r/851/#review405 ::: mobile/android/base/SysInfo.java.in (Diff revision 1) > + private static volatile int sTotalRAM = -1; Inclined to fix this to totalRAM while we're here. ::: mobile/android/base/moz.build (Diff revision 1) > + 'org/mozilla/gecko/SysInfo.java', I slightly question SysInfo's presence in 'constants', but fair enough.
Comment 5•10 years ago
|
||
https://reviewboard.mozilla.org/r/855/#review409 Ship It!
Comment 6•10 years ago
|
||
https://reviewboard.mozilla.org/r/853/#review411 Ship It!
Assignee | ||
Comment 7•10 years ago
|
||
/r/849 - Bug 1102488 - Pre: Remove unused cruft. r=rnewman /r/851 - Bug 1102488 - Part 1: Factor out constants JAR. r=rnewman /r/853 - Bug 1102488 - Part 2a: Move GeckoLoader. /r/855 - Bug 1102488 - Part 2b: Don't preprocess GeckoLoader. /r/857 - Bug 1102488 - Part 3: Output preprocessed files into generated/preprocessed. r=rnewman /r/859 - Bug 1102488 - Part 4: Make FxAccountConstants independent of Logger. r=rnewman Pull down these commits: hg pull review -r d4bc85c5c958781acef3ecb8e0041877af45b3d0
Comment 8•10 years ago
|
||
https://reviewboard.mozilla.org/r/857/#review413 ::: mobile/android/base/fxa/FxAccountConstants.java.in (Diff revision 1) > - } > + // } Ahem?
Assignee | ||
Comment 9•10 years ago
|
||
/r/849 - Bug 1102488 - Pre: Remove unused cruft. r=rnewman /r/851 - Bug 1102488 - Part 1: Factor out constants JAR. r=rnewman /r/853 - Bug 1102488 - Part 2a: Move GeckoLoader. /r/855 - Bug 1102488 - Part 2b: Don't preprocess GeckoLoader. /r/857 - Bug 1102488 - Part 3: Output preprocessed files into generated/preprocessed. r=rnewman /r/859 - Bug 1102488 - Part 4: Make FxAccountConstants independent of Logger. r=rnewman Pull down these commits: hg pull review -r d4bc85c5c958781acef3ecb8e0041877af45b3d0
Comment 10•10 years ago
|
||
https://reviewboard.mozilla.org/r/859/#review415 Fine if you fold in the // from the previous patch.
Assignee | ||
Comment 11•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/fa85f8d8b182 https://hg.mozilla.org/integration/fx-team/rev/8d1d39582e49 https://hg.mozilla.org/integration/fx-team/rev/d2c14599cbab https://hg.mozilla.org/integration/fx-team/rev/48fc328377d4 https://hg.mozilla.org/integration/fx-team/rev/05cf424592e6
Assignee | ||
Comment 12•10 years ago
|
||
This was reviewed by rnewman over in https://reviewboard.mozilla.org/rbmozui/commits/847/ and friends. Pushed in a different order with nits.
Assignee | ||
Updated•10 years ago
|
Attachment #8526375 -
Flags: review?(rnewman) → review+
Backed out in https://hg.mozilla.org/integration/fx-team/rev/23410bbf2161 for robocop failures: https://treeherder.mozilla.org/ui/logviewer.html#?job_id=1259507&repo=fx-team https://treeherder.mozilla.org/ui/logviewer.html#?job_id=1259495&repo=fx-team
Flags: needinfo?(nalexander)
Assignee | ||
Comment 14•9 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=fd170be33719
Assignee | ||
Comment 15•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/5be12b2b704f https://hg.mozilla.org/integration/fx-team/rev/e3a52be782f7 https://hg.mozilla.org/integration/fx-team/rev/ae7b2705bfa7 https://hg.mozilla.org/integration/fx-team/rev/51e6a0c2187b https://hg.mozilla.org/integration/fx-team/rev/f264f1d096a1
Comment 16•9 years ago
|
||
sorry had to back this out in https://treeherder.mozilla.org/ui/#/jobs?repo=fx-team&revision=e09b83770a74 for possible breaking desktop builds like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=1284348&repo=fx-team
Assignee | ||
Comment 17•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e61cf17c8f22 https://hg.mozilla.org/integration/fx-team/rev/830deae4a41a https://hg.mozilla.org/integration/fx-team/rev/51ce636dfed1 https://hg.mozilla.org/integration/fx-team/rev/840208e80c41 https://hg.mozilla.org/integration/fx-team/rev/7a2706f87fe6
Comment 18•9 years ago
|
||
And a CLOBBER touch because random Android bustage isn't any fun. https://hg.mozilla.org/integration/fx-team/rev/80199b6d7ee3
Comment 19•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e61cf17c8f22 https://hg.mozilla.org/mozilla-central/rev/830deae4a41a https://hg.mozilla.org/mozilla-central/rev/51ce636dfed1 https://hg.mozilla.org/mozilla-central/rev/840208e80c41 https://hg.mozilla.org/mozilla-central/rev/7a2706f87fe6 https://hg.mozilla.org/mozilla-central/rev/80199b6d7ee3
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(nalexander)
Assignee | ||
Comment 20•9 years ago
|
||
Attachment #8526375 -
Attachment is obsolete: true
Attachment #8618664 -
Flags: review+
Attachment #8618665 -
Flags: review+
Attachment #8618666 -
Flags: review+
Attachment #8618667 -
Flags: review+
Attachment #8618668 -
Flags: review+
Attachment #8618669 -
Flags: review+
Assignee | ||
Comment 21•9 years ago
|
||
Assignee | ||
Comment 22•9 years ago
|
||
Assignee | ||
Comment 23•9 years ago
|
||
Assignee | ||
Comment 24•9 years ago
|
||
Assignee | ||
Comment 25•9 years ago
|
||
Assignee | ||
Comment 26•9 years ago
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 36 → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•