Closed
Bug 1102518
Opened 10 years ago
Closed 10 years ago
Actually disable tracking protection when user taps "disable" button
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(2 files)
4.55 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
3.47 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Oopsies, we forgot to actually make this button work.
Assignee | ||
Comment 1•10 years ago
|
||
Copied from the desktop implementation: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/urlbarBindings.xml#1860 I'll work on updating the test.
Attachment #8526438 -
Flags: review?(mark.finkle)
Updated•10 years ago
|
Attachment #8526438 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 2•10 years ago
|
||
The current test isn't equipped to check the UI with robocop, so I just simulated what the Java UI does. I think this will lead to a lot fewer intermittent failures. https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b4173fc4f5e3
Attachment #8526461 -
Flags: review?(mark.finkle)
Comment 3•10 years ago
|
||
Comment on attachment 8526461 [details] [diff] [review] Test for disabling tracking protection It took me a moment to figure out why you needed promiseLoadEvent (with the undefined args), but then I realized that the "Session:Reload" will cause a full page reload (not from cache) and the eventType defaults to "load" which will catch the load. Maybe add a comment in there? +1 on not relying on the Java UI!
Attachment #8526461 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/ded64417fabe https://hg.mozilla.org/integration/fx-team/rev/f4e09c6be901
https://hg.mozilla.org/mozilla-central/rev/ded64417fabe https://hg.mozilla.org/mozilla-central/rev/f4e09c6be901
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•