1102527 - Rejoin message no longer shown

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[aleth [:aleth]]

STR
/part followed by /join

Reason: conv.chatRoomFields is set when the code doesn't expect it to be.

Probably a regression from the joining throbber changes.

Comment 1

[aleth [:aleth]]

Attachment: rejoinfix.diff

It was indeed due to the joining throbber changes in the order in which things happen when joining a channel.

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8527238 [details] [diff] [review]
rejoinfix.diff

Review of attachment 8527238 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/protocols/irc/irc.js
@@ +1510,5 @@
> +      }
> +      else if (!conv.chatRoomFields) {
> +        // We are rejoining a channel that was parted by the user.
> +        conv._rejoined = true;
> +      }

Nit: No {}, put the comments on the line above the if statements.

Comment 3

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/a6f0ef227906