1102604 - SysInfo.getLocale() is wrong

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Locale switching and selection, defect)

Description

[Richard Newman [:rnewman]]

/**
     * @return the default system locale, such as "en-US"
     */
    public static String getLocale() {
        return java.util.Locale.getDefault().toString().replace('_', '-');
    }

This will be wrong for a small set of locales (e.g., Indonesian), and in any case is O_O.

Callers should use BrowserLocaleManager.getLocaleTag(Locale) instead.

Comment 1

[Richard Newman [:rnewman]]

Attachment: SysInfo.getLocale() is wrong. v1

This should do the trick. Not yet tested, though.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8540529 [details] [diff] [review]
SysInfo.getLocale() is wrong. v1

Review of attachment 8540529 [details] [diff] [review]:
-----------------------------------------------------------------

As discussed on IRC, the Sysinfo.getLocale method should actually be removed. lgtm w/ that change.

Comment 3

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/9b7ace653773

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9b7ace653773