1102650 - Selectors with the pseudo class :(-moz-)dir() should be valid when the argument is a valid identifier

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Benjamin Poulain]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_2) AppleWebKit/600.3.6 (KHTML, like Gecko) Version/8.0.2 Safari/600.3.6

Steps to reproduce:

See the following codepen: http://codepen.io/anon/pen/ZYYRrj


Actual results:

The text should be styled green.


Expected results:

The selector is considered invalid. It should be matching nothing instead (http://dev.w3.org/csswg/selectors4/#the-dir-pseudo).

Since it is considered invalid, the universal selector is ignored.

Kudos to Sukolsak Sakshuwong for catching the bug.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Yeah, I don't see any rationale for why it was done the way our code does it.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: Make the :-moz-dir() and :-moz-locale-dir() selectors be valid selectors (matching nothing) with arguments other than rtl and ltr, rather than invalid

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8526592 [details] [diff] [review]
Make the :-moz-dir() and :-moz-locale-dir() selectors be valid selectors (matching nothing) with arguments other than rtl and ltr, rather than invalid

I assume it's OK that we serialize values other than "ltr" and "rtl" after converting them to lowercase?

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I think so, given that CSS values are all case-insensitive, and the values likely to be added are things like tb-rl and tb-lr, or maybe ttb.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ae211c02f12

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0ae211c02f12