Closed Bug 1102658 Opened 10 years ago Closed 10 years ago

Add initial references to the last few AudioData constructor callsite

Categories

(Core :: Audio/Video, defect)

29 Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file)

Attached patch leak-fixSplinter Review
Bug 1100776 missed a few places where we construct AudioData, this could leak if we're flushing and MP4Reader::Output doesn't add a reference.
Attachment #8526474 - Flags: review?(bobbyholley)
Comment on attachment 8526474 [details] [diff] [review]
leak-fix

Review of attachment 8526474 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. Sorry for missing that.
Attachment #8526474 - Flags: review?(bobbyholley) → review+
https://hg.mozilla.org/mozilla-central/rev/d2828e139d25
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.