1102673 - Mozilla Japan staff cannot see Air Mozilla staff only events

Status: VERIFIED FIXED

(Webtools Graveyard :: Air Mozilla, defect)

Description

[Guillermo Huerta [Disabled MoCo account]]

Moved over from Service Now.  We need to add @mozilla-japan.org to the list of domains for Mozilla staff.

------
Tomoya ASAI (dynamis)

In Air Mozilla, we have some videos or meetings requiring permissions. Only @mozilla.com users or mozillians with NDA can access them.
Mozilla Japan employee should access to them (same as Mozilla Corp employee) but our LDAP account is not @mozilla.com. Our account is @mozilla-japan.org like [e-mail] or [e-mail].

So, please set permission for @mozilla-japan.org users in Air Mozilla.

Comment 1

[Peter Bengtsson [:peterbe]]

This has already been set actually. See
https://github.com/mozilla/airmozilla/blob/master/airmozilla/settings/base.py#L77

It was added there April 23 2014
https://github.com/mozilla/airmozilla/commit/bd928f781d2c33f1f12c4267aeb6e4a6bd17c867

I'm wondering if perhaps it's because some people signed in BEFORE April 23 and that might have "tainted" the user records or something. 

Can you test with an email address that you know is relatively new?

Comment 2

[Richard A Milewski[:richard]]

Tomoya,

Can you confirm that this is failing for recent additions as well?

Comment 3

[dynamis (Tomoya ASAI)]

I <[e-mail]> and other old account cannot see:
https://air.mozilla.org/moco-special/

New staff <[e-mail]> can see it. So as Peter say, old account created before April 23 2014 should be updated.

Comment 4

[Richard A Milewski[:richard]]

Is this a Persona issue or an AirMo issue?

Comment 5

[Peter Bengtsson [:peterbe]]

(In reply to Richard A Milewski[:richard] from comment #4)
> Is this a Persona issue or an AirMo issue?

This is a Peter issue :)

I might need to build in a new functionality to the User Manager.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/fea03d61b7c7331cf99f8576614eec7a192a22d8
fixes bug 1102673 - ability to make a user NOT contributor

https://github.com/mozilla/airmozilla/commit/832632f418e23d52066f05368b5ac995aacad226
Merge pull request #143 from peterbe/bug-1102673-ability-to-make-a-user-not-contributor

fixes bug 1102673 - ability to make a user NOT contributor

Comment 7

[Peter Bengtsson [:peterbe]]

(In reply to dynamis (Tomoya ASAI) from comment #3)
> I <[e-mail]> and other old account cannot see:
> https://air.mozilla.org/moco-special/
> 
> New staff <[e-mail]> can see it. So as Peter say, old
> account created before April 23 2014 should be updated.

So were able to reproduce the problem and a fix has been put into code and that code has been pushed to the server. 

To use it you'll need to log out and log back in again. 
Please change the bug to verified if it works then for you.

Comment 8

[dynamis (Tomoya ASAI)]

(In reply to Peter Bengtsson [:peterbe] from comment #7)
> To use it you'll need to log out and log back in again. 
> Please change the bug to verified if it works then for you.

Works fine! Thanks!