pwcac is still getting built

VERIFIED FIXED in M10

Status

()

defect
P3
normal
VERIFIED FIXED
20 years ago
2 years ago

People

(Reporter: colin, Assigned: gagan)

Tracking

Trunk
DEC
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Reporter

Description

20 years ago
lib/libpwcac (password caching I thing) is still getting built (from
the main Makefile). I believe this is part of the old networking code
and should therefore be ifdef'd out of the standard build now.

Comment 1

20 years ago
It is, and under linux/unix it´s save to be removed or #ifdefed from the main
makefile.

Updated

20 years ago
Target Milestone: M10

Comment 2

20 years ago
Andreas, can you send us a diff?

Comment 3

20 years ago
sure:

Index: mozilla/Makefile.in
===================================================================
RCS file: /cvsroot/mozilla/Makefile.in,v
retrieving revision 1.39
diff -c -r1.39 Makefile.in
*** Makefile.in 1999/07/29 00:43:33     1.39
--- Makefile.in 1999/08/02 21:39:59
***************
*** 63,73 ****
    modules/oji                 \
    modules/plugin              \
    modules/libjar              \
-   caps                                \
    lib/xp                      \
    lib/libpwcac                        \
    htmlparser                  \
!   expat             \
    gfx                         \
    dom                         \
    view                                \
--- 63,81 ----
    modules/oji                 \
    modules/plugin              \
    modules/libjar              \
    lib/xp                      \
+   caps                                \
+   $(NSNULL)
+
+ #ifndef NECKO
+ DIRS +=                       \
    lib/libpwcac                        \
+   $(NSNULL)
+ #endif
+
+ DIRS +=                               \
    htmlparser                  \
!   expat             \
    gfx                         \
    dom                         \
    view                                \


have fun
Assignee

Updated

20 years ago
Status: NEW → RESOLVED
Last Resolved: 20 years ago
Resolution: --- → FIXED
Assignee

Comment 4

20 years ago
Fixed.

Updated

20 years ago
Status: RESOLVED → REOPENED

Updated

20 years ago
Status: REOPENED → RESOLVED
Last Resolved: 20 years ago20 years ago
Resolution: FIXED → WONTFIX

Updated

20 years ago
Status: RESOLVED → REOPENED

Comment 5

20 years ago
I feel soooo dumb. Don't us #ifndef in Makefiles unless you really want
something to happen. Use ifndef instead. Reopened the bug. As soon as I return
from work I will check again if its really save to remove libpwcac from the
makefile.

Updated

20 years ago
Resolution: WONTFIX → ---

Comment 6

20 years ago
clearing Won't Fix Resolution due to reopen

Updated

20 years ago
Status: REOPENED → RESOLVED
Last Resolved: 20 years ago20 years ago
Resolution: --- → FIXED

Comment 7

20 years ago
I better had looked if gagan really used my non working patch before reopening,
this is fixed.

Updated

20 years ago
Status: RESOLVED → VERIFIED

Comment 8

20 years ago
Bulk move of all Necko (to be deleted component) bugs to new Networking

component.
You need to log in before you can comment on or make changes to this bug.