pwcac is still getting built

VERIFIED FIXED in M10

Status

()

defect
P3
normal
VERIFIED FIXED
20 years ago
3 years ago

People

(Reporter: colin, Assigned: gagan)

Tracking

Trunk
DEC
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

lib/libpwcac (password caching I thing) is still getting built (from
the main Makefile). I believe this is part of the old networking code
and should therefore be ifdef'd out of the standard build now.
It is, and under linux/unix it´s save to be removed or #ifdefed from the main
makefile.
Target Milestone: M10
Andreas, can you send us a diff?
sure:

Index: mozilla/Makefile.in
===================================================================
RCS file: /cvsroot/mozilla/Makefile.in,v
retrieving revision 1.39
diff -c -r1.39 Makefile.in
*** Makefile.in 1999/07/29 00:43:33     1.39
--- Makefile.in 1999/08/02 21:39:59
***************
*** 63,73 ****
    modules/oji                 \
    modules/plugin              \
    modules/libjar              \
-   caps                                \
    lib/xp                      \
    lib/libpwcac                        \
    htmlparser                  \
!   expat             \
    gfx                         \
    dom                         \
    view                                \
--- 63,81 ----
    modules/oji                 \
    modules/plugin              \
    modules/libjar              \
    lib/xp                      \
+   caps                                \
+   $(NSNULL)
+
+ #ifndef NECKO
+ DIRS +=                       \
    lib/libpwcac                        \
+   $(NSNULL)
+ #endif
+
+ DIRS +=                               \
    htmlparser                  \
!   expat             \
    gfx                         \
    dom                         \
    view                                \


have fun
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Fixed.
Status: RESOLVED → REOPENED
Status: REOPENED → RESOLVED
Closed: 20 years ago20 years ago
Resolution: FIXED → WONTFIX
Status: RESOLVED → REOPENED
I feel soooo dumb. Don't us #ifndef in Makefiles unless you really want
something to happen. Use ifndef instead. Reopened the bug. As soon as I return
from work I will check again if its really save to remove libpwcac from the
makefile.
Resolution: WONTFIX → ---
clearing Won't Fix Resolution due to reopen
Status: REOPENED → RESOLVED
Closed: 20 years ago20 years ago
Resolution: --- → FIXED
I better had looked if gagan really used my non working patch before reopening,
this is fixed.
Status: RESOLVED → VERIFIED
Bulk move of all Necko (to be deleted component) bugs to new Networking

component.
You need to log in before you can comment on or make changes to this bug.