11028 - pwcac is still getting built

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Colin Blake]

lib/libpwcac (password caching I thing) is still getting built (from
the main Makefile). I believe this is part of the old networking code
and should therefore be ifdef'd out of the standard build now.

Comment 1

[Andreas Otte]

It is, and under linux/unix it´s save to be removed or #ifdefed from the main
makefile.

Comment 2

[Warren Harris]

Andreas, can you send us a diff?

Comment 3

[Andreas Otte]

sure:

Index: mozilla/Makefile.in
===================================================================
RCS file: /cvsroot/mozilla/Makefile.in,v
retrieving revision 1.39
diff -c -r1.39 Makefile.in
*** Makefile.in 1999/07/29 00:43:33     1.39
--- Makefile.in 1999/08/02 21:39:59
***************
*** 63,73 ****
    modules/oji                 \
    modules/plugin              \
    modules/libjar              \
-   caps                                \
    lib/xp                      \
    lib/libpwcac                        \
    htmlparser                  \
!   expat             \
    gfx                         \
    dom                         \
    view                                \
--- 63,81 ----
    modules/oji                 \
    modules/plugin              \
    modules/libjar              \
    lib/xp                      \
+   caps                                \
+   $(NSNULL)
+
+ #ifndef NECKO
+ DIRS +=                       \
    lib/libpwcac                        \
+   $(NSNULL)
+ #endif
+
+ DIRS +=                               \
    htmlparser                  \
!   expat             \
    gfx                         \
    dom                         \
    view                                \


have fun

Comment 4

[Gagan]

Fixed.

Comment 5

[Andreas Otte]

I feel soooo dumb. Don't us #ifndef in Makefiles unless you really want
something to happen. Use ifndef instead. Reopened the bug. As soon as I return
from work I will check again if its really save to remove libpwcac from the
makefile.

Comment 6

[leger]

clearing Won't Fix Resolution due to reopen

Comment 7

[Andreas Otte]

I better had looked if gagan really used my non working patch before reopening,
this is fixed.

Comment 8

[leger]

Bulk move of all Necko (to be deleted component) bugs to new Networking

component.