Fixed -Wparentheses warnings found in mingw build.

RESOLVED FIXED in mozilla37

Status

()

Core
Widget: Win32
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla37
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Created attachment 8526626 [details] [diff] [review]
fix

I wrote this patch when the warning was threated as an error by default for a while. I'm marking the bug as Widget, because the problem found in nsTextStore.cpp seems like a real bug.
Attachment #8526626 - Flags: review?(jmathies)

Comment 1

3 years ago
Hmm, I can approve some of this, but not all. for example -
/js/src/jit/ExecutableAllocatorWin.cpp
that change has to go through the js team member who works on this code. Also the changes to
dom/plugins/ipc/PluginHangUIParent.cpp 
need to go through bsmedberg or bent.

I think you should break this up a little better.

Updated

3 years ago
Attachment #8526626 - Flags: review?(jmathies) → review-
(Assignee)

Comment 2

3 years ago
Created attachment 8529003 [details] [diff] [review]
gfx and widget part

OK, I will attach splitted versions.
Attachment #8526626 - Attachment is obsolete: true
Attachment #8529003 - Flags: review?(jmathies)
(Assignee)

Comment 3

3 years ago
Created attachment 8529005 [details] [diff] [review]
js part
Attachment #8529005 - Flags: review?(jorendorff)
(Assignee)

Comment 4

3 years ago
Created attachment 8529006 [details] [diff] [review]
dom part
Attachment #8529006 - Flags: review?(bent.mozilla)
(Assignee)

Comment 5

3 years ago
Created attachment 8529007 [details] [diff] [review]
toolkit part
Attachment #8529007 - Flags: review?(roc)
Comment on attachment 8529006 [details] [diff] [review]
dom part

Looks like this is Aaron's code.
Attachment #8529006 - Flags: review?(bent.mozilla) → review?(aklotz)

Updated

3 years ago
Attachment #8529006 - Flags: review?(aklotz) → review+

Updated

3 years ago
Attachment #8529003 - Flags: review?(jmathies) → review+
Comment on attachment 8529005 [details] [diff] [review]
js part

Review of attachment 8529005 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8529005 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/b2f0ec4a521e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.