Closed Bug 1102804 Opened 5 years ago Closed 5 years ago

Fixed -Wparentheses warnings found in mingw build.

Categories

(Core :: Widget: Win32, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(4 files, 1 obsolete file)

Attached patch fix (obsolete) — Splinter Review
I wrote this patch when the warning was threated as an error by default for a while. I'm marking the bug as Widget, because the problem found in nsTextStore.cpp seems like a real bug.
Attachment #8526626 - Flags: review?(jmathies)
Hmm, I can approve some of this, but not all. for example -
/js/src/jit/ExecutableAllocatorWin.cpp
that change has to go through the js team member who works on this code. Also the changes to
dom/plugins/ipc/PluginHangUIParent.cpp 
need to go through bsmedberg or bent.

I think you should break this up a little better.
Attachment #8526626 - Flags: review?(jmathies) → review-
OK, I will attach splitted versions.
Attachment #8526626 - Attachment is obsolete: true
Attachment #8529003 - Flags: review?(jmathies)
Attached patch js partSplinter Review
Attachment #8529005 - Flags: review?(jorendorff)
Attached patch dom partSplinter Review
Attachment #8529006 - Flags: review?(bent.mozilla)
Attached patch toolkit partSplinter Review
Attachment #8529007 - Flags: review?(roc)
Comment on attachment 8529006 [details] [diff] [review]
dom part

Looks like this is Aaron's code.
Attachment #8529006 - Flags: review?(bent.mozilla) → review?(aklotz)
Attachment #8529006 - Flags: review?(aklotz) → review+
Attachment #8529003 - Flags: review?(jmathies) → review+
Comment on attachment 8529005 [details] [diff] [review]
js part

Review of attachment 8529005 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8529005 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/b2f0ec4a521e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.