Closed
Bug 1102804
Opened 10 years ago
Closed 9 years ago
Fixed -Wparentheses warnings found in mingw build.
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(4 files, 1 obsolete file)
3.97 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
926 bytes,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
2.17 KB,
patch
|
bugzilla
:
review+
|
Details | Diff | Splinter Review |
3.91 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
I wrote this patch when the warning was threated as an error by default for a while. I'm marking the bug as Widget, because the problem found in nsTextStore.cpp seems like a real bug.
Attachment #8526626 -
Flags: review?(jmathies)
Comment 1•10 years ago
|
||
Hmm, I can approve some of this, but not all. for example - /js/src/jit/ExecutableAllocatorWin.cpp that change has to go through the js team member who works on this code. Also the changes to dom/plugins/ipc/PluginHangUIParent.cpp need to go through bsmedberg or bent. I think you should break this up a little better.
Updated•9 years ago
|
Attachment #8526626 -
Flags: review?(jmathies) → review-
Assignee | ||
Comment 2•9 years ago
|
||
OK, I will attach splitted versions.
Attachment #8526626 -
Attachment is obsolete: true
Attachment #8529003 -
Flags: review?(jmathies)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8529005 -
Flags: review?(jorendorff)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8529006 -
Flags: review?(bent.mozilla)
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8529007 -
Flags: review?(roc)
Attachment #8529007 -
Flags: review?(roc) → review+
Comment on attachment 8529006 [details] [diff] [review] dom part Looks like this is Aaron's code.
Attachment #8529006 -
Flags: review?(bent.mozilla) → review?(aklotz)
Updated•9 years ago
|
Attachment #8529006 -
Flags: review?(aklotz) → review+
Updated•9 years ago
|
Attachment #8529003 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Thanks for reviews. https://hg.mozilla.org/integration/mozilla-inbound/rev/d7703af312e8 https://hg.mozilla.org/integration/mozilla-inbound/rev/aab6ac7b88ce https://hg.mozilla.org/integration/mozilla-inbound/rev/6486de06f958
Whiteboard: [leave open]
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6486de06f958 https://hg.mozilla.org/mozilla-central/rev/aab6ac7b88ce https://hg.mozilla.org/mozilla-central/rev/d7703af312e8
Comment 9•9 years ago
|
||
Comment on attachment 8529005 [details] [diff] [review] js part Review of attachment 8529005 [details] [diff] [review]: ----------------------------------------------------------------- Thanks.
Attachment #8529005 -
Flags: review?(jorendorff) → review+
Assignee | ||
Comment 10•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2f0ec4a521e
Whiteboard: [leave open]
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b2f0ec4a521e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•