Closed Bug 1102815 Opened 10 years ago Closed 9 years ago

mingw builds assert in WindowsCrtPatch.h.

Categories

(Firefox Build System :: General, defect)

x86_64
Windows Phone 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file, 1 obsolete file)

1.10 KB, patch
glandium
: review+
Details | Diff | Splinter Review
Attached patch fix (obsolete) — Splinter Review
It asserts on mozglue.dll being loaded. That's because we don't yet support delay load in mingw builds. However, that shouldn't be a problem in this case because mingw builds don't use msvcr120.dll (and even if they did, we probably don't care that they wouldn't work on WinXP SP2). My proposed patch changes the code to assert only in builds that use the hook. The other solution would be to explicitly disable asserts on mingw.
Attachment #8526636 - Flags: review?(dmajor)
Comment on attachment 8526636 [details] [diff] [review]
fix

Seems to me you should just define XRE_DONT_SUPPORT_XPSP2 in toolkit/xre/nsWindowsWMain.cpp on mingw builds.
Attachment #8526636 - Flags: review?(dmajor) → review-
And while you're there, please make the metro builds set XRE_DONT_SUPPORT_XPSP2 instead of special-casing MOZ_METRO in toolkit/xre/nsWindowsWMain.cpp.
Attached patch fix v2Splinter Review
The attached patch uses XRE_DONT_SUPPORT_XPSP2 instead.
Attachment #8526636 - Attachment is obsolete: true
Attachment #8526678 - Flags: review?(mh+mozilla)
Attachment #8526678 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/9dffe0f511c9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.