1102851 - Layout of formatted log view makes it hard to use

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[James Graham [:jgraham]]

It feels like the layout of the formatted log view makes it hard to use. The most important information is arguably the summary of errors, which is squashed into a scrolling frame in the corner and doesn't have helpful colour coding or anything. By contrast a lot of screen real-estate is given to the build properties, much of which is empty.

I think there are probably some low-hangling fruit here like re-balancing the top row and adding formatting to the summary frame. In the longer term, I wonder if it would be worth considering a more substantial redesign. For example perhaps there shouldn't be a seperate summary / full view, but a single view with the ability to expand context around a given log message, or something. Or maybe there could be navigation in a collapsable sidebar. The build information could probably be arranged horizinally rather than vertically taking up one line by default and again expanding to take up multiple lines to view more details on request. It also seems helpful to be able to filter to see just errors or just failures.

Comment 1

[Jonathan Griffin (:jgriffin)]

See also bug 1102988 which Ted just filed about the lack of blobber upload url's on this page.  I agree a redesign is warranted at some point.

Comment 2

[Jonathan French (:jfrench)]

I haven't yet sorted why the failure steps don't/can't occupy the entire remaining width of the upper panel, depending whether there is a failure step or not. But I have some minor tweaks to reduce the font sizing in the upper run data area, and relinkify the revision hash.

I won't officially assign myself this bug given its broader goals, but I'll reference my PR against this one.

Comment 3

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR410-supplemental

Referencing my PR410 here, pending later review after PR408 lands.

Comment 4

[Jonathan French (:jfrench)]

Comment on attachment 8574419 [details] [review]
treeherder-ui-PR410-supplemental

Setting Ed for review of #410 during camd's pto.

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8574419 [details] [review]
treeherder-ui-PR410-supplemental

Thank you :-)

Comment 6

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/98fdeb5e74d2844b07553fd7a47628ead318b8ff
Bug 1102851 - Relinkify logviewer revision and reduce run-data font

https://github.com/mozilla/treeherder-ui/commit/5e95b24162911ef918b2acb78a9a7d362fe53c4f
Merge pull request #410 from tojonmz/relinkify-log-revision

Bug 1102851 - Relinkify logviewer revision and reduce run-data font

Comment 7

[Jonathan French (:jfrench)]

I'll check the above, once it is pushed to stage/prod.

I might pick away at other LHF/papercuts here when I can, for now I'll leave myself unassigned in case somebody wants to work on some of the lengthier changes mentioned in the description.

Comment 8

[Jonathan French (:jfrench)]

Verified the fix/improvement above in comment 6 is on stage, and looks correct.

Comment 9

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/4c5c604f2b10bec090b773433e12e5f69816a735
Bug 1102851 - Relinkify logviewer revision and reduce run-data font

https://github.com/mozilla/treeherder/commit/92e3c4dd8944e3b5dd4605470a9f8920d3b3770d
Merge pull request #410 from tojonmz/relinkify-log-revision

Bug 1102851 - Relinkify logviewer revision and reduce run-data font

Comment 10

[Jonathan French (:jfrench)]

(In reply to James Graham [:jgraham] from comment #0)
> summary of errors ... doesn't have helpful colour coding or anything

That part has now been addressed within the current Logviewer, as part of bug 1057341.

Comment 11

[Jonathan French (:jfrench)]

Attachment: logviewerContentsPanelMock_rev1

I'd done a speculative mock before Whistler (attached, and equivalent link below) which may have potential to either replace or just augment the current top right failure steps container. Saving space, perhaps allowing hover-copy of the clicked failure line, providing better context where you are in the file, etc.
http://invis.io/RF3IRN2H5

I also wonder if there isn't some existing open source file viewer library (or similar) which already does these things and we would just integrate, but I haven't found any yet.

Comment 12

[Jonathan French (:jfrench)]

I'm still hoping to at least get the 'where am I in the file' part of the mock (slider with location) above done for Q3, but likely not the selection/nav part. I've been fixing a lot of other good ROI logviewer and other bugs during the quarter. See meta bug 1182178 for Q3 logviewer goals and bugs fixed.

Comment 13

[Jonathan French (:jfrench)]

:goma is working on line link/sharing in bug 1108764 which will create new UI and interaction in the same area; so I will probably hold off on any related 'where am I in the file' slider work until that is landed.