1102852 - [EME] gmp-decryption.h should allow the CDM to indicate the type of the message emitted

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Henri Sivonen (:hsivonen)]

The SessionMessage() method in http://dxr.mozilla.org/mozilla-central/source/dom/media/gmp/gmp-api/gmp-decryption.h#128 does not allow the CDM to specifify the type of the message per 
https://w3c.github.io/encrypted-media/#idl-def-MediaKeyMessageType
and
https://www.w3.org/Bugs/Public/show_bug.cgi?id=27124
.

Expected the method to take an enum with four possible values:
License request
License renewal
License release
Individualization request

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

jw: would you be able to take this bug? It involves changing the GMP API and the EME JS APIs to include the MediaKeyMessageType enum on MediaKeyMessageEvent, and removing the destinationURL from MediaKeyMessageEvent.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

jw: would you be able to take this bug? It involves changing the GMP API and the EME JS APIs to include the MediaKeyMessageType enum on MediaKeyMessageEvent, and removing the destinationURL from MediaKeyMessageEvent.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

sure.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1102852_add_MediaKeyMessageType_to_MediaKeyMessageEvent-v1.patch

add MediaKeyMessageType to and remove destinationURL from MediaKeyMessageEvent.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8547544 [details] [diff] [review]
1102852_add_MediaKeyMessageType_to_MediaKeyMessageEvent-v1.patch

Review of attachment 8547544 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome.

We should probably change the mochitests to verify that the MediaKeyMessage events we receive have an expected type too.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8547544 [details] [diff] [review]
1102852_add_MediaKeyMessageType_to_MediaKeyMessageEvent-v1.patch

Review of attachment 8547544 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/gmp/gmp-api/gmp-decryption.h
@@ +218,5 @@
>    kGMPPersistentSession = 1,
>    kGMPSessionInvalid = 2 // Must always be last.
>  };
>  
> +#define GMP_API_DECRYPTOR "eme-decrypt-v3"

You'll also need to change the .info files so that they report that they support the new API name:

/dom/media/gmp-plugin/fake.info
/media/gmp-clearkey/0.1/clearkey.info

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1102852_add_MediaKeyMessageType_to_MediaKeyMessageEvent-v2.patch

address nits in comment 6.

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

JW: can this land?

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

try: https://tbpl.mozilla.org/?tree=Try&rev=dbeb6aaf6584

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

need to rebase...

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1102852_add_MediaKeyMessageType_to_MediaKeyMessageEvent-v3.patch

rebase.

Comment 12

[Carsten Book [:Tomcat]]

needs dom peer review for bundling: dom/webidl/MediaKeyMessageEvent.webidl changes

Comment 13

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8548601 [details] [diff] [review]
1102852_add_MediaKeyMessageType_to_MediaKeyMessageEvent-v3.patch

Hi bz,
Can you review dom/webidl/MediaKeyMessageEvent.webidl? Thanks.

Comment 14

[JW Wang [:jwwang] [:jw_wang]]

spec: https://w3c.github.io/encrypted-media/#idl-def-MediaKeyMessageEvent

Comment 15

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8548601 [details] [diff] [review]
1102852_add_MediaKeyMessageType_to_MediaKeyMessageEvent-v3.patch

r=me

Comment 16

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ed0ad42de73

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4ed0ad42de73

Comment 18

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Beta patch

Patch for beta branch as part of EME platform uplift.

Comment 19

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c7d212eecc8e

Comment 20

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8572285 [details] [diff] [review]
Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.

Comment 21

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8572285 [details] [diff] [review]
Beta patch

Previously approved as part of the EME platform landing on Beta.