1102889 - Remove unnecessary mozasyncpanzoom attribute from remote iframes

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

For a while now the mozasyncpanzoom attribute has not been needed on remote iframes. The gecko code at [1] that checks for it is not invoked on platforms that have the APZ pref enabled (which B2G does) and so any gaia code that sets this attribute is redundant. It doesn't hurt to leave it, but this might be a good cleanup task for somebody.

(Note: prior to bug 1072498 the gecko code there used to check for the dom.browser_frames.useAsyncPanZoom pref which has also been true on B2G for a few releases now).

[1] http://mxr.mozilla.org/mozilla-central/source/dom/base/nsFrameLoader.cpp?rev=4c2d59fd05fb#2108

Comment 1

[Kevin Grandon :kgrandon]

Sure, let's clean this up in gaia.

Comment 2

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1102889_remove_unnecessary_apz to mozilla-b2g:master

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8526798 [details] [review]
[PullReq] KevinGrandon:bug_1102889_remove_unnecessary_apz to mozilla-b2g:master

Thanks for filing this Kats. I always had assumed these attributes were extra, so better to get rid of them to reduce confusion. Flagging a few people for review:

Cristian for the home screen, and John for the TV app part of things. Kats - if you could also put your R+ (or F+) on this I would appreciate it. Thanks!

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8526798 [details] [review]
[PullReq] KevinGrandon:bug_1102889_remove_unnecessary_apz to mozilla-b2g:master

LGTM!

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8526798 [details] [review]
[PullReq] KevinGrandon:bug_1102889_remove_unnecessary_apz to mozilla-b2g:master

Thanks Kevin. I had looked and checked the code. r=me.

Comment 6

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8526798 [details] [review]
[PullReq] KevinGrandon:bug_1102889_remove_unnecessary_apz to mozilla-b2g:master

LGTM

Comment 7

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 8

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8526798 [details] [review]
[PullReq] KevinGrandon:bug_1102889_remove_unnecessary_apz to mozilla-b2g:master

Oops, my R+ as well to appease autolander.

Comment 10

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 11

[Kevin Grandon :kgrandon]

Oops, the suggested reviewer list was not right, but I've updated it.

Landed in master: https://github.com/mozilla-b2g/gaia/commit/3798a35036a96d9983d6b57b41ff3bc31e43c14a