Closed Bug 1102917 Opened 9 years ago Closed 8 years ago

Remove the TextureInfo member from client-side Compositable classes

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Platform:
x86_64
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla36

People

(Reporter: nical, Assigned: nical)

Details

Attachments

(1 file)

remove the TextureInfo member from client Compositable classes.
10.47 KB, patch
sotaro
: review+
Details | Diff | Splinter Review 
TextureInfo contains a TextureFlags member which is also in CompositableClient. as a result the member exists twice in some compositable classes, which is a massive footgun. The best would be to remove TextureInfo entirely and just send the CompositableType when creating a CompositableHost, but ContentCLientIncremental uses all of the TextureInfo stuff, so it will be much simpler if we remove TextureInfo after we remove ContentClientIncremental which should happen soon.
In the mean time, let's make sure we don't have a duplicate TextureFlags state in the other client compositable types.
... except for ContentClientIncremental which is going to be removed soon so it's not worth bothering.
Attachment #8526778 - Flags: review?(sotaro.ikeda.g)
Attachment #8526778 - Flags: review?(sotaro.ikeda.g) → review+
https://hg.mozilla.org/mozilla-central/rev/5ee35646d120
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.