1102925 - Build SpiderMonkey as static library without JIT

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, defect)

Description

[Maksim Lebedev]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141105223254

Steps to reproduce:

I expect that this options should work:
--disable-shared-js
--disable-ion
--disable-gcincremental
--disable-gcgenerational
--disable-ctypes


Actual results:

A lot of errors during build:
js\src\jit/Label.h(86) : error C3861: 'MaybeGetIonContext': identifier not found
js\src\jit/Label.h(87) : error C2027: use of undefined type 'js::jit::IonContext'
js\src\jscntxt.h(36) : see declaration of 'js::jit::IonContext'
And more others.


Expected results:

Will be good if SpiderMonkey can be built:
1) from root of m-c
2) into static library
3) without JIT support

Comment 1

[Maksim Lebedev]

> js\src\moz.build
I really don't understand why? :
FireFox 33: all of JIT files can be included to UNIFIED_SOURCE only if ENABLE_ION was set as true;
FireFox m-c: all of JIT files be included always (I mean without check of ENABLE_ION)

Comment 2

[Hannes Verschore [:h4writer]]

IIRC Brian adjusted this, since we were always breaking --disable-ion builds. He proposed to still build everything but don't enable ionmonkey (The backend of IonMonkey in --disable-ion is a dummy representation that has MOZ_CRASH() for all functions). Seems like we still managed to break it?

Another thing. Do we have --disable-jit? Since --disable-ion will only disable ionmonkey. I think it won't disable all jits we have...

Comment 3

[Maksim Lebedev]

(In reply to Hannes Verschore [:h4writer] from comment #2)
Looks like --disable-jit were in FireFox 28 (or earlier). Now I found only --disable-ion.
If anybody can suggest way how to build SpiderMonkey without any JIT's - welcome.

Comment 4

[Tom S. (please needinfo tschuster)]

You can specify --disable-ion and you won't get any working JIT support. There is nothing else.

Comment 5

[Maksim Lebedev]

(In reply to Tom Schuster [:evilpie] from comment #4)
> You can specify --disable-ion and you won't get any working JIT support. There is nothing else.
Unfortunately, option "--disable-ion" does not work (please, see comment 1)

Comment 6

[Maksim Lebedev]

Attachment: disable_ion_part1.diff

I tried to repair build of SpiderMonkey without JIT support.
Can anybody check and put review+ for this patch?

Comment 7

[Terrence Cole [:terrence]]

Comment on attachment 8530865 [details] [diff] [review]
disable_ion_part1.diff

Review of attachment 8530865 [details] [diff] [review]:
-----------------------------------------------------------------

Actually, the GC bits will be better solved by taking bug 1107288 and bug 1107349. Please test with igc and ggc enabled at build time and disabled at runtime, per those bugs. I'm not sure about the moz.build bits. Please re-upload a patch with just that part.

Comment 8

[Maksim Lebedev]

Attachment: disable_ion_part2.diff

Update of patch according with GC bugs.

Result of patch: looks like, js_static.lib is made.

Comment 9

[Tom S. (please needinfo tschuster)]

I just tested locally, and --disable-ion builds are not busted. So your changes to moz.build are not necessary, we changed to a stubbed none backend in bug 1102925.

Comment 10

[Tom S. (please needinfo tschuster)]

Sorry Bug 1042833.

Comment 11

[Terrence Cole [:terrence]]

Comment on attachment 8540697 [details] [diff] [review]
disable_ion_part2.diff

Review of attachment 8540697 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/TypedObject.cpp
@@ +1665,5 @@
>           owner->as<ArrayBufferObject>().hasInlineData()))
>      {
>          newData += reinterpret_cast<uint8_t *>(owner) - reinterpret_cast<uint8_t *>(oldOwner);
>          typedObj.setData(newData);
> +#ifdef JSGC_GENERATIONAL

The JSGC_GENERATIONAL and JSGC_INCREMENTAL flags do not exist anymore, so this just unconditionally disables the code here -- probably not what you meant to do. What errors are you hitting when building tip?

Comment 12

[Maksim Lebedev]

(In reply to Tom Schuster [:evilpie] from comment #9)
> I just tested locally, and --disable-ion builds are not busted. So your
> changes to moz.build are not necessary, we changed to a stubbed none backend
> in bug 1102925.
You want to say that all files in js/src/jit should be included in build? Is it correct?
In this case how I can disable JIT in SpiderMonkey, or how I can check that JIT is disabled?

Comment 13

[Jan de Mooij [:jandem]]

(In reply to Maksim Lebedev from comment #12)
> You want to say that all files in js/src/jit should be included in build? Is
> it correct?

Correct. Build with --disable-ion and the JIT will be disabled.

Comment 14

[Hannes Verschore [:h4writer]]

Comment on attachment 8540697 [details] [diff] [review]
disable_ion_part2.diff

Review of attachment 8540697 [details] [diff] [review]:
-----------------------------------------------------------------

Removing f?, since the r- from terrence